minor #43844 [Console] [AppVeyor] Fix EOL in the tests (wkania)

fabpot · fabpot · commit bd084951465a · 2021-10-31T07:51:29.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [Console] [AppVeyor] Fix EOL in the tests | Q | A | ------------- | --- | Branch? | 5.4  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | License | MIT [Probably caused by this fix](#43665) AppVeyor run tests on Windows and tests with EOL [failing](https://ci.appveyor.com/project/fabpot/symfony/builds/41346183#L1559) ![image](https://user-images.githubusercontent.com/57155526/139556426-38a1b371-8c23-4211-a0cd-c31dc26034a7.png) `@derrabus` pls review Commits ------- d4a9e6e [Console][AppVeyor] Fix EOL in the tests
diff --git a/src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php b/src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php
@@ -82,7 +82,7 @@ public function provideInputAndCurrentOptionValues()
     public function testCompleteCommandName(array $input, array $suggestions)
     {
         $this->execute(['--current' => '1', '--input' => $input]);
-        $this->assertEquals(implode("\n", $suggestions)."\n", $this->tester->getDisplay());
+        $this->assertEquals(implode("\n", $suggestions).\PHP_EOL, $this->tester->getDisplay());
     }
 
     public function provideCompleteCommandNameInputs()
@@ -98,7 +98,7 @@ public function provideCompleteCommandNameInputs()
     public function testCompleteCommandInputDefinition(array $input, array $suggestions)
     {
         $this->execute(['--current' => '2', '--input' => $input]);
-        $this->assertEquals(implode("\n", $suggestions)."\n", $this->tester->getDisplay());
+        $this->assertEquals(implode("\n", $suggestions).\PHP_EOL, $this->tester->getDisplay());
     }
 
     public function provideCompleteCommandInputDefinitionInputs()

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function provideInputAndCurrentOptionValues()`
`82`	`82`	`public function testCompleteCommandName(array $input, array $suggestions)`
`83`	`83`	`{`
`84`	`84`	`$this->execute(['--current' => '1', '--input' => $input]);`
`85`		`- $this->assertEquals(implode("\n", $suggestions)."\n", $this->tester->getDisplay());`
	`85`	`+ $this->assertEquals(implode("\n", $suggestions).\PHP_EOL, $this->tester->getDisplay());`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`public function provideCompleteCommandNameInputs()`
`@@ -98,7 +98,7 @@ public function provideCompleteCommandNameInputs()`
`98`	`98`	`public function testCompleteCommandInputDefinition(array $input, array $suggestions)`
`99`	`99`	`{`
`100`	`100`	`$this->execute(['--current' => '2', '--input' => $input]);`
`101`		`- $this->assertEquals(implode("\n", $suggestions)."\n", $this->tester->getDisplay());`
	`101`	`+ $this->assertEquals(implode("\n", $suggestions).\PHP_EOL, $this->tester->getDisplay());`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`public function provideCompleteCommandInputDefinitionInputs()`