Don’t use substr()

ausi · ausi · commit bce33c4925be · 2017-09-14T17:10:24.000+02:00
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -359,7 +359,7 @@ public function makePathRelative($endPath, $startPath)
         }
 
         $stripDriveLetter = function ($path) {
-            if (strlen($path) > 2 && substr($path, 1, 2) === ':/' && ctype_alpha($path[0])) {
+            if (strlen($path) > 2 && ':' === $path[1] && '/' === $path[2] && ctype_alpha($path[0])) {
                 return substr($path, 2);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ public function makePathRelative($endPath, $startPath)`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`$stripDriveLetter = function ($path) {`
`362`		`- if (strlen($path) > 2 && substr($path, 1, 2) === ':/' && ctype_alpha($path[0])) {`
	`362`	`+ if (strlen($path) > 2 && ':' === $path[1] && '/' === $path[2] && ctype_alpha($path[0])) {`
`363`	`363`	`return substr($path, 2);`
`364`	`364`	`}`
`365`	`365`