minor #53135 fix tests (xabbuh)

xabbuh · xabbuh · commit bb836c4d6988 · 2023-12-19T12:16:30.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- fix tests | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 12f8ab4 fix tests
diff --git a/src/Symfony/Component/HttpKernel/Tests/Controller/ArgumentResolver/RequestPayloadValueResolverTest.php b/src/Symfony/Component/HttpKernel/Tests/Controller/ArgumentResolver/RequestPayloadValueResolverTest.php
@@ -665,14 +665,11 @@ public function testQueryValidationErrorCustomStatusCode()
     public function testRequestPayloadValidationErrorCustomStatusCode()
     {
         $content = '{"price": 50, "title": ["not a string"]}';
-        $payload = new RequestPayload(50);
         $serializer = new Serializer([new ObjectNormalizer()], ['json' => new JsonEncoder()]);
 
         $validator = $this->createMock(ValidatorInterface::class);
-        $validator->expects($this->once())
-            ->method('validate')
-            ->with($payload)
-            ->willReturn(new ConstraintViolationList([new ConstraintViolation('Test', null, [], '', null, '')]));
+        $validator->expects($this->never())
+            ->method('validate');
 
         $resolver = new RequestPayloadValueResolver($serializer, $validator);
 
@@ -693,7 +690,6 @@ public function testRequestPayloadValidationErrorCustomStatusCode()
             $this->assertSame(400, $e->getStatusCode());
             $this->assertInstanceOf(ValidationFailedException::class, $validationFailedException);
             $this->assertSame(sprintf('This value should be of type %s.', class_exists(InvalidTypeException::class) ? 'string' : 'unknown'), $validationFailedException->getViolations()[0]->getMessage());
-            $this->assertSame('Test', $validationFailedException->getViolations()[1]->getMessage());
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -665,14 +665,11 @@ public function testQueryValidationErrorCustomStatusCode()`
`665`	`665`	`public function testRequestPayloadValidationErrorCustomStatusCode()`
`666`	`666`	`{`
`667`	`667`	`$content = '{"price": 50, "title": ["not a string"]}';`
`668`		`- $payload = new RequestPayload(50);`
`669`	`668`	`$serializer = new Serializer([new ObjectNormalizer()], ['json' => new JsonEncoder()]);`
`670`	`669`
`671`	`670`	`$validator = $this->createMock(ValidatorInterface::class);`
`672`		`- $validator->expects($this->once())`
`673`		`- ->method('validate')`
`674`		`- ->with($payload)`
`675`		`- ->willReturn(new ConstraintViolationList([new ConstraintViolation('Test', null, [], '', null, '')]));`
	`671`	`+ $validator->expects($this->never())`
	`672`	`+ ->method('validate');`
`676`	`673`
`677`	`674`	`$resolver = new RequestPayloadValueResolver($serializer, $validator);`
`678`	`675`
`@@ -693,7 +690,6 @@ public function testRequestPayloadValidationErrorCustomStatusCode()`
`693`	`690`	`$this->assertSame(400, $e->getStatusCode());`
`694`	`691`	`$this->assertInstanceOf(ValidationFailedException::class, $validationFailedException);`
`695`	`692`	`$this->assertSame(sprintf('This value should be of type %s.', class_exists(InvalidTypeException::class) ? 'string' : 'unknown'), $validationFailedException->getViolations()[0]->getMessage());`
`696`		`- $this->assertSame('Test', $validationFailedException->getViolations()[1]->getMessage());`
`697`	`693`	`}`
`698`	`694`	`}`
`699`	`695`	`}`