minor #38119 Remove some leftover for HHVM support (fabpot)

fabpot · fabpot · commit bb3bc7fc48e6 · 2020-09-09T07:23:40.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- Remove some leftover for HHVM support | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets |  | License | MIT | Doc PR | n/a Commits ------- cf9e756 Remove some leftover for HHVM support
diff --git a/src/Symfony/Component/Debug/ErrorHandler.php b/src/Symfony/Component/Debug/ErrorHandler.php
@@ -489,7 +489,7 @@ public function handleError($type, $message, $file, $line)
         if ($this->isRecursive) {
             $log = 0;
         } else {
-            if (\PHP_VERSION_ID < (\PHP_VERSION_ID < 70400 ? 70316 : 70404) && !\defined('HHVM_VERSION')) {
+            if (\PHP_VERSION_ID < (\PHP_VERSION_ID < 70400 ? 70316 : 70404)) {
                 $currentErrorHandler = set_error_handler('var_dump');
                 restore_error_handler();
             }
@@ -501,7 +501,7 @@ public function handleError($type, $message, $file, $line)
             } finally {
                 $this->isRecursive = false;
 
-                if (\PHP_VERSION_ID < (\PHP_VERSION_ID < 70400 ? 70316 : 70404) && !\defined('HHVM_VERSION')) {
+                if (\PHP_VERSION_ID < (\PHP_VERSION_ID < 70400 ? 70316 : 70404)) {
                     set_error_handler($currentErrorHandler);
                 }
             }
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php
@@ -194,10 +194,6 @@ public function testCookieOptions()
 
     public function testSessionOptions()
     {
-        if (\defined('HHVM_VERSION')) {
-            $this->markTestSkipped('HHVM is not handled in this test case.');
-        }
-
         $options = [
             'url_rewriter.tags' => 'a=href',
             'cache_expire' => '200',
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php
@@ -84,9 +84,6 @@ public function testClosureCaster()
 
     public function testFromCallableClosureCaster()
     {
-        if (\defined('HHVM_VERSION_ID')) {
-            $this->markTestSkipped('Not for HHVM.');
-        }
         $var = [
             (new \ReflectionMethod($this, __FUNCTION__))->getClosure($this),
             (new \ReflectionMethod(__CLASS__, 'stub'))->getClosure(),

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,7 @@ public function handleError($type, $message, $file, $line)`
`489`	`489`	`if ($this->isRecursive) {`
`490`	`490`	`$log = 0;`
`491`	`491`	`} else {`
`492`		`- if (\PHP_VERSION_ID < (\PHP_VERSION_ID < 70400 ? 70316 : 70404) && !\defined('HHVM_VERSION')) {`
	`492`	`+ if (\PHP_VERSION_ID < (\PHP_VERSION_ID < 70400 ? 70316 : 70404)) {`
`493`	`493`	`$currentErrorHandler = set_error_handler('var_dump');`
`494`	`494`	`restore_error_handler();`
`495`	`495`	`}`
`@@ -501,7 +501,7 @@ public function handleError($type, $message, $file, $line)`
`501`	`501`	`} finally {`
`502`	`502`	`$this->isRecursive = false;`
`503`	`503`
`504`		`- if (\PHP_VERSION_ID < (\PHP_VERSION_ID < 70400 ? 70316 : 70404) && !\defined('HHVM_VERSION')) {`
	`504`	`+ if (\PHP_VERSION_ID < (\PHP_VERSION_ID < 70400 ? 70316 : 70404)) {`
`505`	`505`	`set_error_handler($currentErrorHandler);`
`506`	`506`	`}`
`507`	`507`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,6 @@ public function testClosureCaster()`
`84`	`84`
`85`	`85`	`public function testFromCallableClosureCaster()`
`86`	`86`	`{`
`87`		`- if (\defined('HHVM_VERSION_ID')) {`
`88`		`- $this->markTestSkipped('Not for HHVM.');`
`89`		`- }`
`90`	`87`	`$var = [`
`91`	`88`	`(new \ReflectionMethod($this, __FUNCTION__))->getClosure($this),`
`92`	`89`	`(new \ReflectionMethod(__CLASS__, 'stub'))->getClosure(),`