bug #22258 [DI] Autowiring and factories are incompatible with each others (nicolas-grekas)

fabpot · fabpot · commit bad24d39357a · 2017-04-03T15:14:48.000-07:00
This PR was merged into the 2.8 branch. Discussion ---------- [DI] Autowiring and factories are incompatible with each others | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 9b60163 [DI] Autowiring and factories are incompatible with each others
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -74,6 +74,10 @@ public function process(ContainerBuilder $container)
      */
     private function completeDefinition($id, Definition $definition)
     {
+        if ($definition->getFactory() || $definition->getFactoryClass(false) || $definition->getFactoryService(false)) {
+            throw new RuntimeException(sprintf('Service "%s" can use either autowiring or a factory, not both.', $id));
+        }
+
         if (!$reflectionClass = $this->getReflectionClass($id, $definition)) {
             return;
         }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
@@ -465,6 +465,22 @@ public function provideAutodiscoveredAutowiringOrder()
             array('CannotBeAutowiredReverseOrder'),
         );
     }
+
+    /**
+     * @expectedException \Symfony\Component\DependencyInjection\Exception\RuntimeException
+     * @expectedExceptionMessage Service "a" can use either autowiring or a factory, not both.
+     */
+    public function testWithFactory()
+    {
+        $container = new ContainerBuilder();
+
+        $container->register('a', __NAMESPACE__.'\A')
+            ->setFactory('foo')
+            ->setAutowired(true);
+
+        $pass = new AutowirePass();
+        $pass->process($container);
+    }
 }
 
 class Foo

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,10 @@ public function process(ContainerBuilder $container)`
`74`	`74`	`*/`
`75`	`75`	`private function completeDefinition($id, Definition $definition)`
`76`	`76`	`{`
	`77`	`+ if ($definition->getFactory() \|\| $definition->getFactoryClass(false) \|\| $definition->getFactoryService(false)) {`
	`78`	`+ throw new RuntimeException(sprintf('Service "%s" can use either autowiring or a factory, not both.', $id));`
	`79`	`+ }`
	`80`	`+`
`77`	`81`	`if (!$reflectionClass = $this->getReflectionClass($id, $definition)) {`
`78`	`82`	`return;`
`79`	`83`	`}`