bug #30102 [Workflow] Graphviz dumper escape not always a string (Korbeil)

lyrixx · lyrixx · commit bac2c9973310 · 2019-02-08T11:00:05.000+01:00
This PR was merged into the 4.2 branch. Discussion ---------- [Workflow] Graphviz dumper escape not always a string | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A The `escape` function takes a string as parameter but it can be a `bool` (see `findTransitions` method in same class). In this PR I allow any type in `escape` and does escaping only for `string`. Commits ------- 1b17192 escape function does not always take a string
diff --git a/src/Symfony/Component/Workflow/Dumper/GraphvizDumper.php b/src/Symfony/Component/Workflow/Dumper/GraphvizDumper.php
@@ -204,9 +204,9 @@ protected function dotize($id)
     /**
      * @internal
      */
-    protected function escape(string $string): string
+    protected function escape($value): string
     {
-        return addslashes($string);
+        return \is_bool($value) ? ($value ? '1' : '0') : \addslashes($value);
     }
 
     private function addAttributes(array $attributes): string

Original file line number	Diff line number	Diff line change
`@@ -204,9 +204,9 @@ protected function dotize($id)`
`204`	`204`	`/**`
`205`	`205`	`* @internal`
`206`	`206`	`*/`
`207`		`- protected function escape(string $string): string`
	`207`	`+ protected function escape($value): string`
`208`	`208`	`{`
`209`		`- return addslashes($string);`
	`209`	`+ return \is_bool($value) ? ($value ? '1' : '0') : \addslashes($value);`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`private function addAttributes(array $attributes): string`