bug #25926 [Form] Fixed Button::setParent() when already submitted (HeahDude)

fabpot · fabpot · commit ba8fb60bbd1b · 2018-01-26T15:13:14.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fixed Button::setParent() when already submitted | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ The `Button` does not respect the [FormInterface](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/FormInterface.php#L28), by extension the `SubmitButton` neither. Commits ------- 9f0c7bf Fixed Button::setParent() when already submitted
diff --git a/src/Symfony/Component/Form/Button.php b/src/Symfony/Component/Form/Button.php
@@ -106,6 +106,10 @@ public function offsetUnset($offset)
      */
     public function setParent(FormInterface $parent = null)
     {
+        if ($this->submitted) {
+            throw new AlreadySubmittedException('You cannot set the parent of a submitted button');
+        }
+
         $this->parent = $parent;
     }
 
diff --git a/src/Symfony/Component/Form/Tests/ButtonTest.php b/src/Symfony/Component/Form/Tests/ButtonTest.php
@@ -30,18 +30,34 @@ protected function setUp()
         $this->factory = $this->getMockBuilder('Symfony\Component\Form\FormFactoryInterface')->getMock();
     }
 
+    /**
+     * @expectedException \Symfony\Component\Form\Exception\AlreadySubmittedException
+     */
+    public function testSetParentOnSubmittedButton()
+    {
+        $button = $this->getButtonBuilder('button')
+            ->getForm()
+        ;
+
+        $button->submit('');
+
+        $button->setParent($this->getFormBuilder('form')->getForm());
+    }
+
     /**
      * @dataProvider getDisabledStates
      */
     public function testDisabledIfParentIsDisabled($parentDisabled, $buttonDisabled, $result)
     {
         $form = $this->getFormBuilder('form')
             ->setDisabled($parentDisabled)
-            ->getForm();
+            ->getForm()
+        ;
 
         $button = $this->getButtonBuilder('button')
             ->setDisabled($buttonDisabled)
-            ->getForm();
+            ->getForm()
+        ;
 
         $button->setParent($form);
 

Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,10 @@ public function offsetUnset($offset)`
`106`	`106`	`*/`
`107`	`107`	`public function setParent(FormInterface $parent = null)`
`108`	`108`	`{`
	`109`	`+ if ($this->submitted) {`
	`110`	`+ throw new AlreadySubmittedException('You cannot set the parent of a submitted button');`
	`111`	`+ }`
	`112`	`+`
`109`	`113`	`$this->parent = $parent;`
`110`	`114`	`}`
`111`	`115`