10000 merged branch Burgov/builder_getparent_call_fix (PR #4556) · symfony/symfony@ba8333a · GitHub
[go: up one dir, main page]

Skip to content

Commit ba8333a

Browse files
committed
merged branch Burgov/builder_getparent_call_fix (PR #4556)
Commits ------- 1e83206 [Form] FormBuilderInterface->getParent() doesn't take any arguments (anymore) Discussion ---------- [Form] FormBuilderInterface->getParent() doesn't take any arguments (anymore) Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes --------------------------------------------------------------------------- by travisbot at 2012-06-12T13:43:25Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1601018) (merged 9826ca66 into 7783969). --------------------------------------------------------------------------- by travisbot at 2012-06-12T13:51:33Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1601030) (merged 1e83206 into 7783969). --------------------------------------------------------------------------- by bschussek at 2012-06-12T18:21:56Z :+1: Thanks again! :)
2 parents 28f6c58 + 1e83206 commit ba8333a

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/Symfony/Component/Form/FormFactory.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,7 @@ public function createNamedBuilder($name, $type, $data = null, array $options =
172172

173173
array_unshift($types, $type);
174174

175-
// getParent() cannot see default options set by this type nor
176-
// default options set by parent types
177-
// As a result, the options always have to be checked for
178-
// existence with isset() before using them in this method.
179-
$type = $type->getParent($options);
175+
$type = $type->getParent();
180176
}
181177

182178
// Top-down determination of the default options

0 commit comments

Comments
 (0)
0