Change strpos to str_contains and place it first since it is faster than preg_match

Konstantin Bogomolov · Konstantin Bogomolov · commit ba77bd6c2e52 · 2021-07-25T20:34:22.000+05:30
diff --git a/src/Symfony/Component/Form/Extension/Core/EventListener/FixUrlProtocolListener.php b/src/Symfony/Component/Form/Extension/Core/EventListener/FixUrlProtocolListener.php
@@ -36,7 +36,7 @@ public function onSubmit(FormEvent $event)
     {
         $data = $event->getData();
 
-        if ($this->defaultProtocol && $data && \is_string($data) && !preg_match('~^[\w+.-]+://~', $data) && false === strpos($data, '/')) {
+        if ($this->defaultProtocol && $data && \is_string($data) && !str_contains($data, '/') && !preg_match('~^[\w+.-]+://~', $data)) {
             $event->setData($this->defaultProtocol.'://'.$data);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function onSubmit(FormEvent $event)`
`36`	`36`	`{`
`37`	`37`	`$data = $event->getData();`
`38`	`38`
`39`		`- if ($this->defaultProtocol && $data && \is_string($data) && !preg_match('~^[\w+.-]+://~', $data) && false === strpos($data, '/')) {`
	`39`	`+ if ($this->defaultProtocol && $data && \is_string($data) && !str_contains($data, '/') && !preg_match('~^[\w+.-]+://~', $data)) {`
`40`	`40`	`$event->setData($this->defaultProtocol.'://'.$data);`
`41`	`41`	`}`
`42`	`42`	`}`