fix(process): use a pipe for stderr in pty mode to avoid mixed output between stdout and stderr

joelwurtz · joelwurtz · commit ba755a8e294e · 2025-03-10T18:11:00.000+01:00
diff --git a/src/Symfony/Component/Process/Pipes/UnixPipes.php b/src/Symfony/Component/Process/Pipes/UnixPipes.php
@@ -74,7 +74,7 @@ public function getDescriptors(): array
             return [
                 ['pty'],
                 ['pty'],
-                ['pty'],
+                ['pipe', 'w'], // stderr needs to be in a pipe to correctly split error and output, since PHP will use the same stream for both
             ];
         }
 
diff --git a/src/Symfony/Component/Process/Tests/ProcessTest.php b/src/Symfony/Component/Process/Tests/ProcessTest.php
@@ -540,6 +540,20 @@ public function testExitCodeTextIsNullWhenExitCodeIsNull()
         $this->assertNull($process->getExitCodeText());
     }
 
+    public function testStderrNotMixedWithStdout()
+    {
+        if (!Process::isPtySupported()) {
+            $this->markTestSkipped('PTY is not supported on this operating system.');
+        }
+
+        $process = $this->getProcess('echo "foo" && echo "bar" >&2');
+        $process->setPty(true);
+        $process->run();
+
+        $this->assertSame("foo\r\n", $process->getOutput());
+        $this->assertSame("bar\n", $process->getErrorOutput());
+    }
+
     public function testPTYCommand()
     {
         if (!Process::isPtySupported()) {

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public function getDescriptors(): array`
`74`	`74`	`return [`
`75`	`75`	`['pty'],`
`76`	`76`	`['pty'],`
`77`		`- ['pty'],`
	`77`	`+ ['pipe', 'w'], // stderr needs to be in a pipe to correctly split error and output, since PHP will use the same stream for both`
`78`	`78`	`];`
`79`	`79`	`}`
`80`	`80`