8000 deprecate the framework.templating option · symfony/symfony@ba241ce · GitHub
[go: up one dir, main page]

Skip to content

Commit ba241ce

Browse files
committed
deprecate the framework.templating option
1 parent 0d5258a commit ba241ce

File tree

6 files changed

+11
-1
lines changed

6 files changed

+11
-1
lines changed

UPGRADE-4.3.md

+1
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ Form
7171
FrameworkBundle
7272
---------------
7373

74+
* Deprecated the `framework.templating` option, use Twig instead.
7475
* Not passing the project directory to the constructor of the `AssetsInstallCommand` is deprecated. This argument will
7576
be mandatory in 5.0.
7677
* Deprecated the "Psr\SimpleCache\CacheInterface" / "cache.app.simple" service, use "Symfony\Contracts\Cache\CacheInterface" / "cache.app" instead.

UPGRADE-5.0.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ Form
169169
FrameworkBundle
170170
---------------
171171

172+
* Remved the `framework.templating` option, use Twig instead.
172173
* The project dir argument of the constructor of `AssetsInstallCommand` is required.
173-
174174
* Removed support for `bundle:controller:action` syntax to reference controllers. Use `serviceOrFqcn::method`
175175
instead where `serviceOrFqcn` is either the service ID when using controllers as services or the FQCN of the controller.
176176

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ CHANGELOG
44
4.3.0
55
-----
66

7+
* Deprecated the `framework.templating` option, use Twig instead.
78
* Added `WebTestAssertionsTrait` (included by default in `WebTestCase`)
89
* Renamed `Client` to `KernelBrowser`
910
* Not passing the project directory to the constructor of the `AssetsInstallCommand` is deprecated. This argument will

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

+1
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,7 @@ private function addTemplatingSection(ArrayNodeDefinition $rootNode)
605605
->arrayNode('templating')
606606
->info('templating configuration')
607607
->canBeEnabled()
608+
->setDeprecated('The "%path%.%node%" configuration is deprecated since Symfony 4.3. Use the "twig" service directly instead.')
608609
->beforeNormalization()
609610
->ifTrue(function ($v) { return false === $v || \is_array($v) && false === $v['enabled']; })
610611
->then(function () { return ['enabled' => false, 'engines' => false]; })

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php

+3
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ public function testDefaultConfig()
3535
);
3636
}
3737

38+
/**
39+
* @group legacy
40+
*/
3841
public function testDoNoDuplicateDefaultFormResources()
3942
{
4043
$input = ['templating' => [

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

+4
Original file line numberDiff line numberDiff line change
@@ -602,6 +602,9 @@ public function testTemplating()
602602
$this->assertEquals('global_hinclude_template', $container->getParameter('fragment.renderer.hinclude.global_template'), '->registerTemplatingConfiguration() registers the global hinclude.js template');
603603
}
604604

605+
/**
606+
* @group legacy
607+
*/
605608
public function testTemplatingCanBeDisabled()
606609
{
607610
$container = $this->createContainerFromFile('templating_disabled');
@@ -867,6 +870,7 @@ public function testTranslatorMultipleFallbacks()
867870
}
868871

869872
/**
873+
* @group legacy
870874
* @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
871875
*/
872876
public function testTemplatingRequiresAtLeastOneEngine()

0 commit comments

Comments
 (0)
0