Parameterize historySize

jderusse · jderusse · commit b98038cd4844 · 2020-08-07T12:34:05.000+02:00
diff --git a/src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php b/src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
@@ -29,17 +29,17 @@
  */
 class SendFailedMessageForRetryListener implements EventSubscriberInterface
 {
-    private const HISTORY_SIZE = 10;
-
     private $sendersLocator;
     private $retryStrategyLocator;
     private $logger;
+    private $historySize;
 
-    public function __construct(ContainerInterface $sendersLocator, ContainerInterface $retryStrategyLocator, LoggerInterface $logger = null)
+    public function __construct(ContainerInterface $sendersLocator, ContainerInterface $retryStrategyLocator, LoggerInterface $logger = null, int $historySize = 10)
     {
         $this->sendersLocator = $sendersLocator;
         $this->retryStrategyLocator = $retryStrategyLocator;
         $this->logger = $logger;
+        $this->historySize = $historySize;
     }
 
     public function onMessageFailed(WorkerMessageFailedEvent $event)
@@ -85,14 +85,14 @@ private function withLimitedHistory(Envelope $envelope, StampInterface ...$stamp
     {
         foreach ($stamps as $stamp) {
             $history = $envelope->all(get_class($stamp));
-            if (\count($history) < self::HISTORY_SIZE) {
+            if (\count($history) < $this->historySize) {
                 $envelope = $envelope->with($stamp);
                 continue;
             }
 
             $history = \array_merge(
                 [$history[0]],
-                \array_slice($history, -self::HISTORY_SIZE + 2),
+                \array_slice($history, -$this->historySize + 2),
                 [$stamp]
             );
 
diff --git a/src/Symfony/Component/Messenger/Tests/EventListener/SendFailedMessageForRetryListenerTest.php b/src/Symfony/Component/Messenger/Tests/EventListener/SendFailedMessageForRetryListenerTest.php
@@ -82,7 +82,7 @@ public function testEnvelopeKeepOnlyTheLast10Stamps()
         $exception = new \Exception('no!');
         $stamps = \array_merge(
           \array_fill(0, 15, new DelayStamp(1)),
-          \array_fill(0, 3, new RedeliveryStamp(1)),
+          \array_fill(0, 3, new RedeliveryStamp(1))
         );
         $envelope = new Envelope(new \stdClass(), $stamps);
 
