8000 minor #24215 CS: recover no_break_comment (keradus) · symfony/symfony@b973ecf · GitHub
[go: up one dir, main page]
Skip to content

Commit b973ecf

Browse files
fabpotfabpot
committed
minor #24215 CS: recover no_break_comment (keradus)
This PR was merged into the 2.7 branch. Discussion ---------- CS: recover no_break_comment | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a, see CIs | Fixed tickets | n/a | License | MIT | Doc PR | n/a rule was excluded in #24123, yet without any information about it it was not excluded in original form of given PR, it's not part of any commitlog nor any comment, title claims to touch only other rules. this rule shall not be excluded, it's part of PSR and is applied for most places. I added missing ones. Commits ------- 4e9d160 CS: recover no_break_comment
2 parents 800f306 + 4e9d160 commit b973ecf

File tree

7 files changed

+13
-3
lines changed

7 files changed

+13
-3
lines changed

‎.php_cs.dist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ return PhpCsFixer\Config::create()
99
'@Symfony' => true,
1010
'@Symfony:risky' => true,
1111
'array_syntax' => array('syntax' => 'long'),
12-
'no_break_comment' => false,
1312
'protected_to_private' => false,
1413
))
1514
->setRiskyAllowed(true)

‎src/Symfony/Component/Form/Util/ServerParams.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,11 @@ public function getPostMaxSize()
6262

6363
switch (substr($iniMax, -1)) {
6464
case 't': $max *= 1024;
65+
// no break
6566
case 'g': $max *= 1024;
67+
// no break
6668
case 'm': $max *= 1024;
69+
// no break
6770
case 'k': $max *= 1024;
6871
}
6972

‎src/Symfony/Component/HttpFoundation/File/UploadedFile.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,8 +259,11 @@ public static function getMaxFilesize()
259259

260260
switch (substr($iniMax, -1)) {
261261
case 't': $max *= 1024;
262+
// no break
262263
case 'g': $max *= 1024;
264+
// no break
263265
case 'm': $max *= 1024;
266+
// no break
264267
case 'k': $max *= 1024;
265268
}
266269

‎src/Symfony/Component/HttpKernel/DataCollector/MemoryDataCollector.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,11 @@ private function convertToBytes($memoryLimit)
9999

100100
switch (substr($memoryLimit, -1)) {
101101
case 't': $max *= 1024;
102+
// no break
102103
case 'g': $max *= 1024;
104+
// no break
103105
case 'm': $max *= 1024;
106+
// no break
104107
case 'k': $max *= 1024;
105108
}
106109

‎src/Symfony/Component/VarDumper/Cloner/Data.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ private function dumpItem($dumper, $cursor, &$refs, $item)
179179
$item = clone $item;
180180
$item->type = $item->class;
181181
$item->class = $item->value;
182-
// No break;
182+
// no break
183183
case Stub::TYPE_OBJECT:
184184
case Stub::TYPE_RESOURCE:
185185
$withChildren = $children && $cursor->depth !== $this->maxDepth && $this->maxItemsPerDepth;

‎src/Symfony/Component/VarDumper/Dumper/CliDumper.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ protected function dumpKey(Cursor $cursor)
317317
default:
318318
case Cursor::HASH_INDEXED:
319319
$style = 'index';
320+
// no break
320321
case Cursor::HASH_ASSOC:
321322
if (is_int($key)) {
322323
$this->line .= $this->style($style, $key).' => ';
@@ -327,7 +328,7 @@ protected function dumpKey(Cursor $cursor)
327328

328329
case Cursor::HASH_RESOURCE:
329330
$key = "\0~\0".$key;
330-
// No break;
331+
// no break
331332
case Cursor::HASH_OBJECT:
332333
if (!isset($key[0]) || "\0" !== $key[0]) {
333334
$this->line .= '+'.$bin.$this->style('public', $key).': ';

‎src/Symfony/Component/Yaml/Inline.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,7 @@ private static function evaluateScalar($scalar, $references = array())
537537

538538
return $time;
539539
}
540+
// no break
540541
default:
541542
return (string) $scalar;
542543
}

0 commit comments

Comments
 (0)
0