[ErrorHandler] fix parsing @return array<foo> annotations

nicolas-grekas · nicolas-grekas · commit b8cbb93caa66 · 2021-07-15T11:09:11.000+02:00
diff --git a/src/Symfony/Component/ErrorHandler/DebugClassLoader.php b/src/Symfony/Component/ErrorHandler/DebugClassLoader.php
@@ -612,7 +612,7 @@ public function checkAnnotations(\ReflectionClass $refl, string $class): array
                 ;
             }
 
-            if (null !== ($returnType = self::$returnTypes[$class][$method->name] ?? self::MAGIC_METHODS[$method->name] ?? null) && !$method->hasReturnType() && !($doc && preg_match('/\n\s+\* @return +(\S+)/', $doc))) {
+            if (null !== ($returnType = self::$returnTypes[$class][$method->name] ?? self::MAGIC_METHODS[$method->name] ?? null) && !$method->hasReturnType() && !($doc && preg_match('/\n\s+\* @return +([^\s<(]+)/', $doc))) {
                 [$normalizedType, $returnType, $declaringClass, $declaringFile] = \is_string($returnType) ? [$returnType, $returnType, '', ''] : $returnType;
 
                 if ('void' === $normalizedType) {
@@ -640,7 +640,7 @@ public function checkAnnotations(\ReflectionClass $refl, string $class): array
 
             $matches = [];
 
-            if (!$method->hasReturnType() && ((false !== strpos($doc, '@return') && preg_match('/\n\s+\* @return +(\S+)/', $doc, $matches)) || 'void' !== (self::MAGIC_METHODS[$method->name] ?? 'void'))) {
+            if (!$method->hasReturnType() && ((false !== strpos($doc, '@return') && preg_match('/\n\s+\* @return +([^\s<(]+)/', $doc, $matches)) || 'void' !== (self::MAGIC_METHODS[$method->name] ?? 'void'))) {
                 $matches = $matches ?: [1 => self::MAGIC_METHODS[$method->name]];
                 $this->setReturnType($matches[1], $method, $parent);
 

Original file line number	Diff line number	Diff line change
`@@ -612,7 +612,7 @@ public function checkAnnotations(\ReflectionClass $refl, string $class): array`
`612`	`612`	`;`
`613`	`613`	`}`
`614`	`614`
`615`		`- if (null !== ($returnType = self::$returnTypes[$class][$method->name] ?? self::MAGIC_METHODS[$method->name] ?? null) && !$method->hasReturnType() && !($doc && preg_match('/\n\s+\* @return +(\S+)/', $doc))) {`
	`615`	`+ if (null !== ($returnType = self::$returnTypes[$class][$method->name] ?? self::MAGIC_METHODS[$method->name] ?? null) && !$method->hasReturnType() && !($doc && preg_match('/\n\s+\* @return +([^\s<(]+)/', $doc))) {`
`616`	`616`	`[$normalizedType, $returnType, $declaringClass, $declaringFile] = \is_string($returnType) ? [$returnType, $returnType, '', ''] : $returnType;`
`617`	`617`
`618`	`618`	`if ('void' === $normalizedType) {`
`@@ -640,7 +640,7 @@ public function checkAnnotations(\ReflectionClass $refl, string $class): array`
`640`	`640`
`641`	`641`	`$matches = [];`
`642`	`642`
`643`		`- if (!$method->hasReturnType() && ((false !== strpos($doc, '@return') && preg_match('/\n\s+\* @return +(\S+)/', $doc, $matches)) \|\| 'void' !== (self::MAGIC_METHODS[$method->name] ?? 'void'))) {`
	`643`	`+ if (!$method->hasReturnType() && ((false !== strpos($doc, '@return') && preg_match('/\n\s+\* @return +([^\s<(]+)/', $doc, $matches)) \|\| 'void' !== (self::MAGIC_METHODS[$method->name] ?? 'void'))) {`
`644`	`644`	`$matches = $matches ?: [1 => self::MAGIC_METHODS[$method->name]];`
`645`	`645`	`$this->setReturnType($matches[1], $method, $parent);`
`646`	`646`