bug #18490 [LDAP] Free the search result after a search to free memory (hiddewie)

fabpot · fabpot · commit b803680efe92 · 2016-04-13T07:10:49.000-07:00
This PR was merged into the 2.8 branch.

Discussion
----------

[LDAP] Free the search result after a search to free memory

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

7da4453 [LDAP] Free the search result after a search to free memory
diff --git a/src/Symfony/Component/Ldap/LdapClient.php b/src/Symfony/Component/Ldap/LdapClient.php
@@ -84,8 +84,17 @@ public function find($dn, $query, $filter = '*')
         }
 
         $search = ldap_search($this->connection, $dn, $query, $filter);
+
+        if (false === $search) {
+            throw new LdapException(ldap_error($this->connection));
+        }
+
         $infos = ldap_get_entries($this->connection, $search);
 
+        if (false === @ldap_free_result($search)) {
+            throw new LdapException(ldap_error($this->connection));
+        }
+
         if (0 === $infos['count']) {
             return;
         }
