[Bugfix] MemcachedSessionHandler::close() must close connection

grachevko · grachevko · commit b77e76abd219 · 2019-01-06T22:14:05.000+03:00
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcachedSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcachedSessionHandler.php
@@ -62,7 +62,7 @@ public function __construct(\Memcached $memcached, array $options = array())
      */
     public function close()
     {
-        return true;
+        return $this->memcached->quit();
     }
 
     /**
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php
@@ -43,6 +43,7 @@ protected function setUp()
         }
 
         $this->memcached = $this->getMockBuilder('Memcached')->getMock();
+        $this->memcached->method('quit')->willReturn(true);
         $this->storage = new MemcachedSessionHandler(
             $this->memcached,
             array('prefix' => self::PREFIX, 'expiretime' => self::TTL)

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function __construct(\Memcached $memcached, array $options = array())`
`62`	`62`	`*/`
`63`	`63`	`public function close()`
`64`	`64`	`{`
`65`		`- return true;`
	`65`	`+ return $this->memcached->quit();`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ protected function setUp()`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`$this->memcached = $this->getMockBuilder('Memcached')->getMock();`
	`46`	`+ $this->memcached->method('quit')->willReturn(true);`
`46`	`47`	`$this->storage = new MemcachedSessionHandler(`
`47`	`48`	`$this->memcached,`
`48`	`49`	`array('prefix' => self::PREFIX, 'expiretime' => self::TTL)`