8000 minor #51110 [Form] Remove an obsolete phpdoc comment (HeahDude) · symfony/symfony@b69cde8 · GitHub
[go: up one dir, main page]

Skip to content

Commit b69cde8

Browse files
minor #51110 [Form] Remove an obsolete phpdoc comment (HeahDude)
This PR was merged into the 5.4 branch. Discussion ---------- [Form] Remove an obsolete phpdoc comment | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ It seems that the comment was introduced when renaming `guessMinLength` to `guessPattern` 11 years ago (f7200e4#diff-c8f9f12ae6d4b48f0f41c30c0cd9716c41e92563a7ded52264a0eb3540ad04e5). However the comment seems to be about a min length, as is it brings to value when guessing a pattern IMHO, so let's drop it. Commits ------- 3856081 [Form] Remove an obsolete phpdoc comment
2 parents 8b2627b + 3856081 commit b69cde8

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/Symfony/Component/Form/FormTypeGuesserInterface.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,6 @@ public function guessMaxLength(string $class, string $property);
4040
/**
4141
* Returns a guess about the field's pattern.
4242
*
43-
* - When you have a min value, you guess a min length of this min (LOW_CONFIDENCE)
44-
* - Then line below, if this value is a float type, this is wrong so you guess null with MEDIUM_CONFIDENCE to override the previous guess.
45-
* Example:
46-
* You want a float greater than 5, 4.512313 is not valid but length(4.512314) > length(5)
47-
*
48-
* @see https://github.com/symfony/symfony/pull/3927
49-
*
5043
* @return Guess\ValueGuess|null
5144
*/
5245
public function guessPattern(string $class, string $property);

0 commit comments

Comments
 (0)
0