require PHP 8.3 to dump lazy proxies for readonly classes

xabbuh · xabbuh · commit b6506fe95bfd · 2024-02-09T09:32:06.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/LazyServiceDumper.php b/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/LazyServiceDumper.php
@@ -105,7 +105,7 @@ public function getProxyCode(Definition $definition, ?string $id = null): string
 
         if ($asGhostObject) {
             try {
-                return (\PHP_VERSION_ID >= 80200 && $class?->isReadOnly() ? 'readonly ' : '').'class '.$proxyClass.ProxyHelper::generateLazyGhost($class);
+                return (\PHP_VERSION_ID >= 80300 && $class?->isReadOnly() ? 'readonly ' : '').'class '.$proxyClass.ProxyHelper::generateLazyGhost($class);
             } catch (LogicException $e) {
                 throw new InvalidArgumentException(sprintf('Cannot generate lazy ghost for service "%s".', $id ?? $definition->getClass()), 0, $e);
             }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/LazyProxy/PhpDumper/LazyServiceDumperTest.php b/src/Symfony/Component/DependencyInjection/Tests/LazyProxy/PhpDumper/LazyServiceDumperTest.php
@@ -55,7 +55,7 @@ public function testInvalidClass()
     }
 
     /**
-     * @requires PHP 8.2
+     * @requires PHP 8.3
      */
     public function testReadonlyClass()
     {

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public function getProxyCode(Definition $definition, ?string $id = null): string`
`105`	`105`
`106`	`106`	`if ($asGhostObject) {`
`107`	`107`	`try {`
`108`		`- return (\PHP_VERSION_ID >= 80200 && $class?->isReadOnly() ? 'readonly ' : '').'class '.$proxyClass.ProxyHelper::generateLazyGhost($class);`
	`108`	`+ return (\PHP_VERSION_ID >= 80300 && $class?->isReadOnly() ? 'readonly ' : '').'class '.$proxyClass.ProxyHelper::generateLazyGhost($class);`
`109`	`109`	`} catch (LogicException $e) {`
`110`	`110`	`throw new InvalidArgumentException(sprintf('Cannot generate lazy ghost for service "%s".', $id ?? $definition->getClass()), 0, $e);`
`111`	`111`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function testInvalidClass()`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`/**`
`58`		`- * @requires PHP 8.2`
	`58`	`+ * @requires PHP 8.3`
`59`	`59`	`*/`
`60`	`60`	`public function testReadonlyClass()`
`61`	`61`	`{`