minor #16707 [Process] Remove PHP_BINARY existence check (ogizanagi)

fabpot · fabpot · commit b5b1d504b4d5 · 2015-11-28T14:17:09.000+01:00
This PR was merged into the 3.0-dev branch. Discussion ---------- [Process] Remove PHP_BINARY existence check | Q | A | ------------- | --- | Fixed tickets | - | License | MIT `PHP_BINARY` constant will always exists as of PHP >= 5.4. Commits ------- 42a75bc [Process] Remove PHP_BINARY existence check
diff --git a/src/Symfony/Component/Process/PhpExecutableFinder.php b/src/Symfony/Component/Process/PhpExecutableFinder.php
@@ -44,7 +44,7 @@ public function find($includeArgs = true)
         }
 
         // PHP_BINARY return the current sapi executable
-        if (defined('PHP_BINARY') && PHP_BINARY && in_array(PHP_SAPI, array('cli', 'cli-server', 'phpdbg')) && is_file(PHP_BINARY)) {
+        if (PHP_BINARY && in_array(PHP_SAPI, array('cli', 'cli-server', 'phpdbg')) && is_file(PHP_BINARY)) {
             return PHP_BINARY.$args;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public function find($includeArgs = true)`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`// PHP_BINARY return the current sapi executable`
`47`		`- if (defined('PHP_BINARY') && PHP_BINARY && in_array(PHP_SAPI, array('cli', 'cli-server', 'phpdbg')) && is_file(PHP_BINARY)) {`
	`47`	`+ if (PHP_BINARY && in_array(PHP_SAPI, array('cli', 'cli-server', 'phpdbg')) && is_file(PHP_BINARY)) {`
`48`	`48`	`return PHP_BINARY.$args;`
`49`	`49`	`}`
`50`	`50`