minor #36568 [PhpUnitBridge] Improve dirname usage (Jean85)

fabpot · fabpot · commit b3cdf5c98904 · 2020-04-25T14:02:39.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Improve dirname usage | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #36499 | License | MIT This is a very small performance improvement on top of #36539 Commits ------- e721cfd Improve dirname usage
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php b/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
@@ -49,7 +49,7 @@ public function __construct(array $mockedNamespaces = array())
             \PHPUnit_Util_Blacklist::$blacklistedClassNames[__CLASS__] = 2;
         } elseif (method_exists(Blacklist::class, 'addDirectory')) {
             (new BlackList())->getBlacklistedDirectories();
-            Blacklist::addDirectory(\dirname(\dirname((new \ReflectionClass(__CLASS__))->getFileName())));
+            Blacklist::addDirectory(\dirname((new \ReflectionClass(__CLASS__))->getFileName(), 2));
         } else {
             Blacklist::$blacklistedClassNames[__CLASS__] = 2;
         }

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function __construct(array $mockedNamespaces = array())`
`49`	`49`	`\PHPUnit_Util_Blacklist::$blacklistedClassNames[__CLASS__] = 2;`
`50`	`50`	`} elseif (method_exists(Blacklist::class, 'addDirectory')) {`
`51`	`51`	`(new BlackList())->getBlacklistedDirectories();`
`52`		`- Blacklist::addDirectory(\dirname(\dirname((new \ReflectionClass(__CLASS__))->getFileName())));`
	`52`	`+ Blacklist::addDirectory(\dirname((new \ReflectionClass(__CLASS__))->getFileName(), 2));`
`53`	`53`	`} else {`
`54`	`54`	`Blacklist::$blacklistedClassNames[__CLASS__] = 2;`
`55`	`55`	`}`