bug #54714 [Serializer] convert empty CSV header names into numeric keys (xabbuh)

fabpot · fabpot · commit b3baa36324f8 · 2024-05-01T15:56:02.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] convert empty CSV header names into numeric keys | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54709 | License | MIT Commits ------- 93ee57b convert empty CSV header names into numeric keys
diff --git a/src/Symfony/Component/Serializer/Encoder/CsvEncoder.php b/src/Symfony/Component/Serializer/Encoder/CsvEncoder.php
@@ -181,18 +181,24 @@ public function decode(string $data, string $format, array $context = [])
                 $depth = $headerCount[$i];
                 $arr = &$item;
                 for ($j = 0; $j < $depth; ++$j) {
+                    $headerName = $headers[$i][$j];
+
+                    if ('' === $headerName) {
+                        $headerName = $i;
+                    }
+
                     // Handle nested arrays
                     if ($j === ($depth - 1)) {
-                        $arr[$headers[$i][$j]] = $cols[$i];
+                        $arr[$headerName] = $cols[$i];
 
                         continue;
                     }
 
-                    if (!isset($arr[$headers[$i][$j]])) {
-                        $arr[$headers[$i][$j]] = [];
+                    if (!isset($arr[$headerName])) {
+                        $arr[$headerName] = [];
                     }
 
-                    $arr = &$arr[$headers[$i][$j]];
+                    $arr = &$arr[$headerName];
                 }
             }
 
diff --git a/src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php b/src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php
@@ -218,7 +218,13 @@ public function testDecodeEmptyData()
     {
         $data = $this->encoder->decode("\n\n", 'csv');
 
-        $this->assertSame([['' => null]], $data);
+        $this->assertSame([[0 => null]], $data);
+    }
+
+    public function testMultipleEmptyHeaderNamesWithSeparator()
+    {
+        $this->encoder->decode(',.
+,', 'csv');
     }
 
     public function testEncodeVariableStructure()

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,13 @@ public function testDecodeEmptyData()`
`218`	`218`	`{`
`219`	`219`	`$data = $this->encoder->decode("\n\n", 'csv');`
`220`	`220`
`221`		`- $this->assertSame([['' => null]], $data);`
	`221`	`+ $this->assertSame([[0 => null]], $data);`
	`222`	`+ }`
	`223`	`+`
	`224`	`+ public function testMultipleEmptyHeaderNamesWithSeparator()`
	`225`	`+ {`
	`226`	`+ $this->encoder->decode(',.`
	`227`	`+,', 'csv');`
`222`	`228`	`}`
`223`	`229`
`224`	`230`	`public function testEncodeVariableStructure()`