bug #38388 [HttpClient] Always "buffer" empty responses (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit b3a20e406563 · 2020-10-02T15:47:43.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Always "buffer" empty responses | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 03d60fc [HttpClient] Always "buffer" empty responses
diff --git a/src/Symfony/Component/HttpClient/Response/ResponseTrait.php b/src/Symfony/Component/HttpClient/Response/ResponseTrait.php
@@ -115,15 +115,13 @@ public function getContent(bool $throw = true): string
                 return $content;
             }
 
-            if ('HEAD' === $this->info['http_method'] || \in_array($this->info['http_code'], [204, 304], true)) {
-                return '';
+            if (null === $this->content) {
+                throw new TransportException('Cannot get the content of the response twice: buffering is disabled.');
+            }
+        } else {
+            foreach (self::stream([$this]) as $chunk) {
+                // Chunks are buffered in $this->content already
             }
-
-            throw new TransportException('Cannot get the content of the response twice: buffering is disabled.');
-        }
-
-        foreach (self::stream([$this]) as $chunk) {
-            // Chunks are buffered in $this->content already
         }
 
         rewind($this->content);
@@ -376,6 +374,10 @@ public static function stream(iterable $responses, float $timeout = null): \Gene
 
                                 $chunk = new ErrorChunk($response->offset, $e);
                             } else {
+                                if (0 === $response->offset && null === $response->content) {
+                                    $response->content = fopen('php://memory', 'w+');
+                                }
+
                                 $chunk = new LastChunk($response->offset);
                             }
                         } elseif ($chunk instanceof ErrorChunk) {
