[VarDumper] extract error dumping in dedicated method

jschaedl · jschaedl · commit b34fe659804f · 2018-09-23T11:47:57.000+02:00
diff --git a/src/Symfony/Component/VarDumper/Caster/IntlCaster.php b/src/Symfony/Component/VarDumper/Caster/IntlCaster.php
@@ -15,6 +15,7 @@
 
 /**
  * @author Nicolas Grekas <p@tchwork.com>
+ * @author Jan Schädlich <jan.schaedlich@sensiolabs.de>
  */
 class IntlCaster
 {
@@ -25,14 +26,7 @@ public static function castMessageFormatter(\MessageFormatter $c, array $a, Stub
             Caster::PREFIX_VIRTUAL.'pattern' => $c->getPattern(),
         );
 
-        if ($errorCode = $c->getErrorCode()) {
-            $a += array(
-                Caster::PREFIX_VIRTUAL.'error_code' => $errorCode,
-                Caster::PREFIX_VIRTUAL.'error_message' => $c->getErrorMessage(),
-            );
-        }
-
-        return $a;
+        return self::dumpError($c, $a);
     }
 
     public static function castNumberFormatter(\NumberFormatter $c, array $a, Stub $stub, $isNested, $filter = 0)
@@ -45,7 +39,7 @@ public static function castNumberFormatter(\NumberFormatter $c, array $a, Stub $
         if ($filter & Caster::EXCLUDE_VERBOSE) {
             $stub->cut += 3;
 
-            return $a;
+            return self::dumpError($c, $a);
         }
 
         $a += array(
@@ -109,10 +103,15 @@ public static function castNumberFormatter(\NumberFormatter $c, array $a, Stub $
              ),
         );
 
+        return self::dumpError($c, $a);
+    }
+
+    private static function dumpError($c, array $a): array
+    {
         if ($errorCode = $c->getErrorCode()) {
             $a += array(
-                Caster::PREFIX_VIRTUAL.'error_code' => $errorCode,
-                Caster::PREFIX_VIRTUAL.'error_message' => $c->getErrorMessage(),
+                Caster::PREFIX_VIRTUAL . 'error_code' => $errorCode,
+                Caster::PREFIX_VIRTUAL . 'error_message' => $c->getErrorMessage(),
             );
         }
 
