8000 [DoctrineBridge] Refactor type guesser to use constants · symfony/symfony@b306483 · GitHub
[go: up one dir, main page]
Skip to content

Commit b306483

Browse files
enumagenumag
committed
[DoctrineBridge] Refactor type guesser to use constants
1 parent 1ee5ab5 commit b306483

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

‎src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -52,28 +52,28 @@ public function guessType($class, $property)
5252
}
5353

5454
switch ($metadata->getTypeOfField($property)) {
55-
case 'array':
55+
case Type::TARRAY:
5656
return new TypeGuess('collection', array(), Guess::MEDIUM_CONFIDENCE);
57-
case 'boolean':
57+
case Type::BOOLEAN:
5858
return new TypeGuess('checkbox', array(), Guess::HIGH_CONFIDENCE);
59-
case 'datetime':
59+
case Type::DATETIME:
60+
case Type::DATETIMETZ:
6061
case 'vardatetime':
61-
case 'datetimetz':
6262
return new TypeGuess('datetime', array(), Guess::HIGH_CONFIDENCE);
63-
case 'date':
63+
case Type::DATE:
6464
return new TypeGuess('date', array(), Guess::HIGH_CONFIDENCE);
65-
case 'time':
65+
case Type::TIME:
6666
return new TypeGuess('time', array(), Guess::HIGH_CONFIDENCE);
67-
case 'decimal':
68-
case 'float':
67+
case Type::DECIMAL:
68+
case Type::FLOAT:
6969
return new TypeGuess('number', array(), Guess::MEDIUM_CONFIDENCE);
70-
case 'integer':
71-
case 'bigint':
72-
case 'smallint':
70+
case Type::INTEGER:
71+
case Type::BIGINT:
72+
case Type::SMALLINT:
7373
return new TypeGuess('integer', array(), Guess::MEDIUM_CONFIDENCE);
74-
case 'string':
74+
case Type::STRING:
7575
return new TypeGuess('text', array(), Guess::MEDIUM_CONFIDENCE);
76-
case 'text':
76+
case Type::TEXT:
7777
return new TypeGuess('textarea', array(), Guess::MEDIUM_CONFIDENCE);
7878
default:
7979
return new TypeGuess('text', array(), Guess::LOW_CONFIDENCE);
@@ -131,7 +131,7 @@ public function guessMaxLength($class, $property)
131131
return new ValueGuess($mapping['length'], Guess::HIGH_CONFIDENCE);
132132
}
133133

134-
if (in_array($ret[0]->getTypeOfField($property), array('decimal', 'float'))) {
134+
if (in_array($ret[0]->getTypeOfField($property), array(Type::DECIMAL, Type::FLOAT))) {
135135
return new ValueGuess(null, Guess::MEDIUM_CONFIDENCE);
136136
}
137137
}
@@ -144,7 +144,7 @@ public function guessPattern($class, $property)
144144
{
145145
$ret = $this->getMetadata($class);
146146
if ($ret && $ret[0]->hasField($property) && !$ret[0]->hasAssociation($property)) {
147-
if (in_array($ret[0]->getTypeOfField($property), array('decimal', 'float'))) {
147+
if (in_array($ret[0]->getTypeOfField($property), array(Type::DECIMAL, Type::FLOAT))) {
148148
return new ValueGuess(null, Guess::MEDIUM_CONFIDENCE);
149149
}
150150
}

0 commit comments

Comments
 (0)
0