bug #9952 [Translator] Fix Empty translations with Qt files (vlefort)

fabpot · fabpot · commit b2d594daa0fc · 2014-01-07T09:33:09.000+01:00
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #9952). Discussion ---------- [Translator] Fix Empty translations with Qt files | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a | Fixed tickets | no | License | MIT | Doc PR | When you use ts files, QtLinguist, generate empty string for all translations, even if there are not translated yet. It could be a good idea to generate an entry in the MessageCatalogue only if translation value is not empty. Commits ------- 1c220be [Translator] Fix Empty translations with Qt files
diff --git a/src/Symfony/Component/Translation/Loader/QtFileLoader.php b/src/Symfony/Component/Translation/Loader/QtFileLoader.php
@@ -53,11 +53,15 @@ public function load($resource, $locale, $domain = 'messages')
         if ($nodes->length == 1) {
             $translations = $nodes->item(0)->nextSibling->parentNode->parentNode->getElementsByTagName('message');
             foreach ($translations as $translation) {
-                $catalogue->set(
-                    (string) $translation->getElementsByTagName('source')->item(0)->nodeValue,
-                    (string) $translation->getElementsByTagName('translation')->item(0)->nodeValue,
-                    $domain
-                );
+                $translationValue = (string) $translation->getElementsByTagName('translation')->item(0)->nodeValue;
+
+                if (!empty($translationValue)) {
+                    $catalogue->set(
+                        (string) $translation->getElementsByTagName('source')->item(0)->nodeValue,
+                        $translationValue,
+                        $domain
+                    );
+                }
                 $translation = $translation->nextSibling;
             }
             $catalogue->addResource(new FileResource($resource));
