8000 Merge branch '2.8' into 3.1 · symfony/symfony@b23389d · GitHub
[go: up one dir, main page]

Skip to content

Commit b23389d

Browse files
committed
Merge branch '2.8' into 3.1
* 2.8: [VarDumper] Fix test Revert "minor #20011 Use UUID for error codes for Form validator. (Koc)" Use UUID for error codes for Form validator. Use UUID for error codes for Form validator. Fixed regression when exception message swallowed when logging it. [HttpFoundation] Enable memcached tests with the latest memcached extension
2 parents d86fc12 + 8acf80f commit b23389d

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

src/Symfony/Component/Form/Extension/Validator/Constraints/Form.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
*/
1919
class Form extends Constraint
2020
{
21-
const NOT_SYNCHRO 8000 NIZED_ERROR = 1;
22-
const NO_SUCH_FIELD_ERROR = 2;
21+
const NOT_SYNCHRONIZED_ERROR = '1dafa156-89e1-4736-b832-419c2e501fca';
22+
const NO_SUCH_FIELD_ERROR = '6e5212ed-a197-4339-99aa-5654798a4854';
2323

2424
protected static $errorNames = array(
2525
self::NOT_SYNCHRONIZED_ERROR => 'NOT_SYNCHRONIZED_ERROR',

src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ protected function setUp()
3737

3838
parent::setUp();
3939

40-
if (version_compare(phpversion('memcached'), '2.2.0', '>=')) {
41-
$this->markTestSkipped('Tests can only be run with memcached extension 2.1.0 or lower');
40+
if (version_compare(phpversion('memcached'), '2.2.0', '>=') && version_compare(phpversion('memcached'), '3.0.0b1', '<')) {
41+
$this->markTestSkipped('Tests can only be run with memcached extension 2.1.0 or lower, or 3.0.0b1 or higher');
4242
}
4343

4444
$this->memcached = $this->getMock('Memcached');

src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,10 @@ private function sanitizeContext($context)
168168
}
169169

170170
if (is_object($context)) {
171+
if ($context instanceof \Exception) {
172+
return sprintf('Exception(%s): %s', get_class($context), $context->getMessage());
173+
}
174+
171175
return sprintf('Object(%s)', get_class($context));
172176
}
173177

src/Symfony/Component/VarDumper/Tests/Fixtures/Twig.php

Lines changed: 4 additions & 4 deletions
7721
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ public function getDebugInfo()
3131

3232
public function getSource()
3333
{
34-
return '';
34+
return " foo bar
35+
twig source
36+
37+
";
3538
}
3639
}
37-
/* foo bar*/
38-
/* twig source*/
39-
/* */

0 commit comments

Comments
 (0)
0