minor #34985 [FrameworkBundle][ContainerLintCommand] Improve messages when the kernel or the container is not supported (fancyweb)

fabpot · fabpot · commit b1fd5538ad04 · 2019-12-16T07:31:47.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][ContainerLintCommand] Improve messages when the kernel or the container is not supported | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #34865 (comment) | License | MIT | Doc PR | - Minor wording suggested here #34865 (comment) Commits ------- 6986394 [FrameworkBundle][ContainerLintCommand] Improve messages when the kernel or the container is not supported
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php
@@ -80,7 +80,7 @@ private function getContainerBuilder(): ContainerBuilder
 
         if (!$kernel->isDebug() || !(new ConfigCache($kernelContainer->getParameter('debug.container.dump'), true))->isFresh()) {
             if (!$kernel instanceof Kernel) {
-                throw new RuntimeException("This command does not support the console application's kernel.");
+                throw new RuntimeException(sprintf('This command does not support the application kernel: "%s" does not extend "%s".', \get_class($kernel), Kernel::class));
             }
 
             $buildContainer = \Closure::bind(function (): ContainerBuilder {
@@ -93,7 +93,7 @@ private function getContainerBuilder(): ContainerBuilder
             $skippedIds = [];
         } else {
             if (!$kernelContainer instanceof Container) {
-                throw new RuntimeException("This command does not support the console application kernel's container.");
+                throw new RuntimeException(sprintf('This command does not support the application container: "%s" does not extend "%s".', \get_class($kernelContainer), Container::class));
             }
 
             (new XmlFileLoader($container = new ContainerBuilder($parameterBag = new EnvPlaceholderParameterBag()), new FileLocator()))->load($kernelContainer->getParameter('debug.container.dump'));

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ private function getContainerBuilder(): ContainerBuilder`
`80`	`80`
`81`	`81`	`if (!$kernel->isDebug() \|\| !(new ConfigCache($kernelContainer->getParameter('debug.container.dump'), true))->isFresh()) {`
`82`	`82`	`if (!$kernel instanceof Kernel) {`
`83`		`- throw new RuntimeException("This command does not support the console application's kernel.");`
	`83`	`+ throw new RuntimeException(sprintf('This command does not support the application kernel: "%s" does not extend "%s".', \get_class($kernel), Kernel::class));`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`$buildContainer = \Closure::bind(function (): ContainerBuilder {`
`@@ -93,7 +93,7 @@ private function getContainerBuilder(): ContainerBuilder`
`93`	`93`	`$skippedIds = [];`
`94`	`94`	`} else {`
`95`	`95`	`if (!$kernelContainer instanceof Container) {`
`96`		`- throw new RuntimeException("This command does not support the console application kernel's container.");`
	`96`	`+ throw new RuntimeException(sprintf('This command does not support the application container: "%s" does not extend "%s".', \get_class($kernelContainer), Container::class));`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`(new XmlFileLoader($container = new ContainerBuilder($parameterBag = new EnvPlaceholderParameterBag()), new FileLocator()))->load($kernelContainer->getParameter('debug.container.dump'));`