8000 bug #13343 [FrameworkBundle] FormDataCollector should be loaded only … · symfony/symfony@aeec129 · GitHub
[go: up one dir, main page]
Skip to content

Commit aeec129

Browse files
fabpotfabpot
committed
bug #13343 [FrameworkBundle] FormDataCollector should be loaded only if form config is enabled (hason)
This PR was merged into the 2.5 branch. Discussion ---------- [FrameworkBundle] FormDataCollector should be loaded only if form config is enabled | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11407 | License | MIT | Doc PR | - Commits ------- af496ea [FrameworkBundle] FormDataCollector should be loaded only if form config is enabled
2 parents 99a627a + af496ea commit aeec129

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/collectors.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
<parameter key="data_collector.time.class">Symfony\Component\HttpKernel\DataCollector\TimeDataCollector</parameter>
1414
<parameter key="data_collector.memory.class">Symfony\Component\HttpKernel\DataCollector\MemoryDataCollector</parameter>
1515
<parameter key="data_collector.router.class">Symfony\Bundle\FrameworkBundle\DataCollector\RouterDataCollector</parameter>
16-
<parameter key="data_collector.form.class">Symfony\Component\Form\Extension\DataCollector\FormDataCollector</parameter>
17-
<parameter key="data_collector.form.extractor.class">Symfony\Component\Form\Extension\DataCollector\FormDataExtractor</parameter>
1816
</parameters>
1917

2018
<services>
@@ -57,13 +55,5 @@
5755
<tag name="kernel.event_listener" event="kernel.controller" method="onKernelController"/>
5856
<tag name="data_collector" template="@WebProfiler/Collector/router.html.twig" id="router" priority="255" />
5957
</service>
60-
61-
<service id="data_collector.form.extractor" class="%data_collector.form.extractor.class%" />
62-
63-
<service id="data_collector.form" class="%data_collector.form.class%">
64-
<tag name="data_collector" template="@WebProfiler/Collector/form.html.twig" id="form" priority="255" />
65-
<argument type="service" id="data_collector.form.extractor" />
66-
</service>
67-
6858
</services>
6959
</container>

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/form_debug.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
<parameters>
88
<parameter key="form.resolved_type_factory.data_collector_proxy.class">Symfony\Component\Form\Extension\DataCollector\Proxy\ResolvedTypeFactoryDataCollectorProxy</parameter>
99
<parameter key="form.type_extension.form.data_collector.class">Symfony\Component\Form\Extension\DataCollector\Type\DataCollectorTypeExtension</parameter>
10+
<parameter key="data_collector.form.class">Symfony\Component\Form\Extension\DataCollector\FormDataCollector</parameter>
11+
<parameter key="data_collector.form.extractor.class">Symfony\Component\Form\Extension\DataCollector\FormDataExtractor</parameter>
1012
</parameters>
1113

1214
<services>
@@ -22,5 +24,13 @@
2224
<tag name="form.type_extension" alias="form" />
2325
<argument type="service" id="data_collector.form" />
2426
</service>
27+
28+
<!-- DataCollector -->
29+
<service id="data_collector.form.extractor" class="%data_collector.form.extractor.class%" />
30+
31+
<service id="data_collector.form" class="%data_collector.form.class%">
32+
<tag name="data_collector" template="@WebProfiler/Collector/form.html.twig" id="form" priority="255" />
33+
<argument type="service" id="data_collector.form.extractor" />
34+
</service>
2535
</services>
2636
</container>

0 commit comments

Comments
 (0)
0