moved compact mode logic into sprintf

gr8b · gr8b · commit ae4d2213f4af · 2024-12-31T03:30:14.000+02:00
diff --git a/src/Symfony/Component/Yaml/Dumper.php b/src/Symfony/Component/Yaml/Dumper.php
@@ -132,20 +132,11 @@ private function doDump(mixed $input, int $inline = 0, int $indent = 0, int $fla
 
                 $willBeInlined = $inline - 1 <= 0 || !\is_array($value) && $dumpObjectAsInlineMap || !$value;
 
-                if (!$willBeInlined && $compactNestedMapping && \is_array($value)) {
-                    $output .= $prefix.'- '.substr(
-                        $this->dump($value, $inline - 1, $willBeInlined ? 0 : $indent + 2, $flags),
-                        $indent + 2
-                    );
-
-                    continue;
-                }
-
                 $output .= \sprintf('%s%s%s%s',
                     $prefix,
                     $dumpAsMap ? Inline::dump($key, $flags).':' : '-',
-                    $willBeInlined ? ' ' : "\n",
-                    $this->doDump($value, $inline - 1, $willBeInlined ? 0 : $indent + $this->indentation, $flags, $nestingLevel + 1)
+                    $willBeInlined || ($compactNestedMapping && \is_array($value)) ? ' ' : "\n",
+                    $compactNestedMapping && \is_array($value) ? \substr($this->doDump($value, $inline - 1, $indent + 2, $flags, $nestingLevel + 1), $indent + 2) : $this->doDump($value, $inline - 1, $willBeInlined ? 0 : $indent + $this->indentation, $flags, $nestingLevel + 1)
                 ).($willBeInlined ? "\n" : '');
             }
         }
