minor #22271 [Workflow] fix risky tests (xabbuh)

lyrixx · lyrixx · commit ada8a2948bf7 · 2017-04-04T15:01:55.000+02:00
This PR was merged into the 3.2 branch. Discussion ---------- [Workflow] fix risky tests | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 4e661e7 [Workflow] fix risky tests
diff --git a/src/Symfony/Component/Workflow/Tests/Validator/StateMachineValidatorTest.php b/src/Symfony/Component/Workflow/Tests/Validator/StateMachineValidatorTest.php
@@ -94,6 +94,9 @@ public function testValid()
 
         (new StateMachineValidator())->validate($definition, 'foo');
 
+        // the test simply ensures that the validation does not fail (i.e. it does not throw any exceptions)
+        $this->addToAssertionCount(1);
+
         // The graph looks like:
         //
         // +----+     +----+     +---+
diff --git a/src/Symfony/Component/Workflow/Tests/Validator/WorkflowValidatorTest.php b/src/Symfony/Component/Workflow/Tests/Validator/WorkflowValidatorTest.php
@@ -28,6 +28,9 @@ public function testSinglePlaceWorkflowValidatorAndSimpleWorkflow()
         $definition = $this->createSimpleWorkflowDefinition();
 
         (new WorkflowValidator(true))->validate($definition, 'foo');
+
+        // the test simply ensures that the validation does not fail (i.e. it does not throw any exceptions)
+        $this->addToAssertionCount(1);
     }
 
     /**
@@ -60,5 +63,8 @@ public function testSameTransitionNameButNotSamePlace()
         $definition = new Definition($places, $transitions);
 
         (new WorkflowValidator())->validate($definition, 'foo');
+
+        // the test simply ensures that the validation does not fail (i.e. it does not throw any exceptions)
+        $this->addToAssertionCount(1);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ public function testSinglePlaceWorkflowValidatorAndSimpleWorkflow()`
`28`	`28`	`$definition = $this->createSimpleWorkflowDefinition();`
`29`	`29`
`30`	`30`	`(new WorkflowValidator(true))->validate($definition, 'foo');`
	`31`	`+`
	`32`	`+ // the test simply ensures that the validation does not fail (i.e. it does not throw any exceptions)`
	`33`	`+ $this->addToAssertionCount(1);`
`31`	`34`	`}`
`32`	`35`
`33`	`36`	`/**`
`@@ -60,5 +63,8 @@ public function testSameTransitionNameButNotSamePlace()`
`60`	`63`	`$definition = new Definition($places, $transitions);`
`61`	`64`
`62`	`65`	`(new WorkflowValidator())->validate($definition, 'foo');`
	`66`	`+`
	`67`	`+ // the test simply ensures that the validation does not fail (i.e. it does not throw any exceptions)`
	`68`	`+ $this->addToAssertionCount(1);`
`63`	`69`	`}`
`64`	`70`	`}`