Fix test to use REDIS_CLUSTER_HOSTS env variable

darkanakin41 · darkanakin41 · commit ad646928eef5 · 2023-06-07T08:44:18.000+02:00
diff --git a/src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php b/src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php
@@ -17,6 +17,12 @@
 
 class RedisTraitTest extends TestCase
 {
+    public static function setUpBeforeClass(): void
+    {
+        if (!getenv('REDIS_CLUSTER_HOSTS')) {
+            throw new SkippedTestSuiteError('REDIS_CLUSTER_HOSTS env var is not defined.');
+        }
+    }
     /**
      * @dataProvider provideCreateConnection
      */
@@ -25,6 +31,9 @@ public function testCreateConnection(string $dsn, string $expectedClass)
         if (!class_exists($expectedClass)) {
             throw new SkippedTestSuiteError(sprintf('The "%s" class is required.', $expectedClass));
         }
+        if (!getenv('REDIS_CLUSTER_HOSTS')) {
+            throw new SkippedTestSuiteError('REDIS_CLUSTER_HOSTS env var is not defined.');
+        }
 
         $mock = self::getObjectForTrait(RedisTrait::class);
         $connection = $mock::createConnection($dsn);
@@ -34,21 +43,23 @@ public function testCreateConnection(string $dsn, string $expectedClass)
 
     public function provideCreateConnection(): array
     {
+        $hosts = array_map(fn(string $host) => sprintf('host[%s]', $host), explode(' ', getenv('REDIS_CLUSTER_HOSTS')));
+
         return [
             [
-                'dsn' => 'redis:?host[localhost:7000]&redis_cluster=1',
+                'dsn' => sprintf('redis:?%s&redis_cluster=1', $hosts[0]),
                 'expectedClass' => '\RedisCluster',
             ],
             [
-                'dsn' => 'redis:?host[localhost:7000]&redis_cluster=true',
+                'dsn' => sprintf('redis:?%s&redis_cluster=true', $hosts[0]),
                 'expectedClass' => '\RedisCluster',
             ],
             [
-                'dsn' => 'redis:?host[localhost:7000]',
+                'dsn' => sprintf('redis:?%s', $hosts[0]),
                 'expectedClass' => '\Redis',
             ],
             [
-                'dsn' => 'redis:?host[localhost:7000]&host[localhost:7001]',
+                'dsn' => sprintf('redis:?%s', join('&', array_slice($hosts, 0, 2))),
                 'expectedClass' => '\RedisArray',
             ],
         ];
