[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals

PaolaRuby · nicolas-grekas · commit ad63d0b5535e · 2021-07-19T11:49:57.000+02:00
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -940,7 +940,7 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI
             }
         }
 
-        if ($command instanceof SignalableCommandInterface) {
+        if ($command instanceof SignalableCommandInterface && ($this->signalsToDispatchEvent || $command->getSubscribedSignals())) {
             if (!$this->signalRegistry) {
                 throw new RuntimeException('Unable to subscribe to signal events. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
             }
diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -36,6 +36,7 @@
 use Symfony\Component\Console\Output\Output;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Output\StreamOutput;
+use Symfony\Component\Console\SignalRegistry\SignalRegistry;
 use Symfony\Component\Console\Tester\ApplicationTester;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\EventDispatcher\EventDispatcher;
@@ -1861,6 +1862,18 @@ public function testSignal()
         $this->assertTrue($command->signaled);
         $this->assertTrue($dispatcherCalled);
     }
+
+    public function testSignalableCommandInterfaceWithoutSignals()
+    {
+        $command = new SignableCommand();
+
+        $dispatcher = new EventDispatcher();
+        $application = new Application();
+        $application->setAutoExit(false);
+        $application->setDispatcher($dispatcher);
+        $application->add($command);
+        $this->assertSame(0, $application->run(new ArrayInput(['signal'])));
+    }
 }
 
 class CustomApplication extends Application
@@ -1928,7 +1941,7 @@ class SignableCommand extends Command implements SignalableCommandInterface
 
     public function getSubscribedSignals(): array
     {
-        return [\SIGALRM];
+        return SignalRegistry::isSupported() ? [\SIGALRM] : [];
     }
 
     public function handleSignal(int $signal): void

Original file line number	Diff line number	Diff line change
`@@ -940,7 +940,7 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI`
`940`	`940`	`}`
`941`	`941`	`}`
`942`	`942`
`943`		`- if ($command instanceof SignalableCommandInterface) {`
	`943`	`+ if ($command instanceof SignalableCommandInterface && ($this->signalsToDispatchEvent \|\| $command->getSubscribedSignals())) {`
`944`	`944`	`if (!$this->signalRegistry) {`
`945`	`945`	throw new RuntimeException('Unable to subscribe to signal events. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
`946`	`946`	`}`