8000 feature #13756 [3.0][Console] Added type hint (francisbesset) · symfony/symfony@ad1888b · GitHub
[go: up one dir, main page]
Skip to content

Commit ad1888b

Browse files
fabpotfabpot
committed
feature #13756 [3.0][Console] Added type hint (francisbesset)
This PR was submitted for the 2.7 branch but it was merged into the 3.0-dev branch instead (closes #13756). Discussion ---------- [3.0][Console] Added type hint The method `Symfony\Component\Console\Application::renderException()` have 2 parameters not type hint but the PHPDoc reveal types. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - Commits ------- e98c537 [Console] Added type hint
2 parents fffcc24 + e98c537 commit ad1888b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

‎UPGRADE-3.0.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ UPGRADE FROM 2.x to 3.0
8888
$table->render();
8989
```
9090

91+
* Parameters of `renderException()` method of the
92+
`Symfony\Component\Console\Application` are type hinted.
93+
You must add the type hint to your implementations.
94+
9195
### DependencyInjection
9296

9397
* The methods `Definition::setFactoryClass()`,

‎src/Symfony/Component/Console/Application.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ public function asXml($namespace = null, $asDom = false)
666666
* @param \Exception $e An exception instance
667667
* @param OutputInterface $output An OutputInterface instance
668668
*/
669-
public function renderException($e, $output)
669+
public function renderException(\Exception $e, OutputInterface $output)
670670
{
671671
do {
672672
$title = sprintf(' [%s] ', get_class($e));

0 commit comments

Comments
 (0)
0