feature #13756 [3.0][Console] Added type hint (francisbesset)

fabpot · fabpot · commit ad1888b982be · 2015-02-24T12:14:13.000+01:00
This PR was submitted for the 2.7 branch but it was merged into the 3.0-dev branch instead (closes #13756). Discussion ---------- [3.0][Console] Added type hint The method `Symfony\Component\Console\Application::renderException()` have 2 parameters not type hint but the PHPDoc reveal types. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - Commits ------- e98c537 [Console] Added type hint
diff --git a/UPGRADE-3.0.md b/UPGRADE-3.0.md
@@ -88,6 +88,10 @@ UPGRADE FROM 2.x to 3.0
    $table->render();
    ```
 
+* Parameters of `renderException()` method of the
+  `Symfony\Component\Console\Application` are type hinted.
+  You must add the type hint to your implementations.
+
 ### DependencyInjection
 
  * The methods `Definition::setFactoryClass()`,
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -666,7 +666,7 @@ public function asXml($namespace = null, $asDom = false)
      * @param \Exception      $e      An exception instance
      * @param OutputInterface $output An OutputInterface instance
      */
-    public function renderException($e, $output)
+    public function renderException(\Exception $e, OutputInterface $output)
     {
         do {
             $title = sprintf('  [%s]  ', get_class($e));

Original file line number	Diff line number	Diff line change
`@@ -666,7 +666,7 @@ public function asXml($namespace = null, $asDom = false)`
`666`	`666`	`* @param \Exception $e An exception instance`
`667`	`667`	`* @param OutputInterface $output An OutputInterface instance`
`668`	`668`	`*/`
`669`		- public function renderException($e, $output)
	`669`	`+ public function renderException(\Exception $e, OutputInterface $output)`
`670`	`670`	`{`
`671`	`671`	`do {`
`672`	`672`	`$title = sprintf(' [%s] ', get_class($e));`