[Form] Updated checks for the ICU version from 4.5+ to 4.7+ due to test failures with ICU 4.6

webmozart · webmozart · commit ac77c5b2d8d4 · 2012-11-24T14:53:14.000+01:00
diff --git a/tests/Symfony/Tests/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/tests/Symfony/Tests/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -98,8 +98,8 @@ public function testReverseTransformWithGrouping()
 
     public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()
     {
-        if ($this->isLowerThanIcuVersion('4.5')) {
-            $this->markTestSkipped('Please upgrade ICU version to 4.5+');
+        if ($this->isLowerThanIcuVersion('4.7')) {
+            $this->markTestSkipped('Please upgrade ICU version to 4.7+');
         }
 
         \Locale::setDefault('fr');
@@ -119,8 +119,8 @@ public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()
      */
     public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
     {
-        if ($this->isLowerThanIcuVersion('4.5')) {
-            $this->markTestSkipped('Please upgrade ICU version to 4.5+');
+        if ($this->isLowerThanIcuVersion('4.7')) {
+            $this->markTestSkipped('Please upgrade ICU version to 4.7+');
         }
 
         $transformer = new NumberToLocalizedStringTransformer(null, true);
@@ -133,8 +133,8 @@ public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
      */
     public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot_noGroupSep()
     {
-        if ($this->isLowerThanIcuVersion('4.5')) {
-            $this->markTestSkipped('Please upgrade ICU version to 4.5+');
+        if ($this->isLowerThanIcuVersion('4.7')) {
+            $this->markTestSkipped('Please upgrade ICU version to 4.7+');
         }
 
         $transformer = new NumberToLocalizedStringTransformer(null, true);
@@ -153,8 +153,8 @@ public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsDotButNoGroupin
 
     public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()
     {
-        if ($this->isLowerThanIcuVersion('4.5')) {
-            $this->markTestSkipped('Please upgrade ICU version to 4.5+');
+        if ($this->isLowerThanIcuVersion('4.7')) {
+            $this->markTestSkipped('Please upgrade ICU version to 4.7+');
         }
 
         \Locale::setDefault('ak');
@@ -174,8 +174,8 @@ public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()
      */
     public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma()
     {
-        if ($this->isLowerThanIcuVersion('4.5')) {
-            $this->markTestSkipped('Please upgrade ICU version to 4.5+');
+        if ($this->isLowerThanIcuVersion('4.7')) {
+            $this->markTestSkipped('Please upgrade ICU version to 4.7+');
         }
 
         \Locale::setDefault('en');
@@ -189,8 +189,8 @@ public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma()
      */
     public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma_noGroupSep()
     {
-        if ($this->isLowerThanIcuVersion('4.5')) {
-            $this->markTestSkipped('Please upgrade ICU version to 4.5+');
+        if ($this->isLowerThanIcuVersion('4.7')) {
+            $this->markTestSkipped('Please upgrade ICU version to 4.7+');
         }
 
         \Locale::setDefault('en');

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,8 @@ public function testReverseTransformWithGrouping()`
`98`	`98`
`99`	`99`	`public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()`
`100`	`100`	`{`
`101`		`- if ($this->isLowerThanIcuVersion('4.5')) {`
`102`		`- $this->markTestSkipped('Please upgrade ICU version to 4.5+');`
	`101`	`+ if ($this->isLowerThanIcuVersion('4.7')) {`
	`102`	`+ $this->markTestSkipped('Please upgrade ICU version to 4.7+');`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`\Locale::setDefault('fr');`
`@@ -119,8 +119,8 @@ public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()`
`119`	`119`	`*/`
`120`	`120`	`public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()`
`121`	`121`	`{`
`122`		`- if ($this->isLowerThanIcuVersion('4.5')) {`
`123`		`- $this->markTestSkipped('Please upgrade ICU version to 4.5+');`
	`122`	`+ if ($this->isLowerThanIcuVersion('4.7')) {`
	`123`	`+ $this->markTestSkipped('Please upgrade ICU version to 4.7+');`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`$transformer = new NumberToLocalizedStringTransformer(null, true);`
`@@ -133,8 +133,8 @@ public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()`
`133`	`133`	`*/`
`134`	`134`	`public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot_noGroupSep()`
`135`	`135`	`{`
`136`		`- if ($this->isLowerThanIcuVersion('4.5')) {`
`137`		`- $this->markTestSkipped('Please upgrade ICU version to 4.5+');`
	`136`	`+ if ($this->isLowerThanIcuVersion('4.7')) {`
	`137`	`+ $this->markTestSkipped('Please upgrade ICU version to 4.7+');`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`$transformer = new NumberToLocalizedStringTransformer(nu F5C4 ll, true);`
`@@ -153,8 +153,8 @@ public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsDotButNoGroupin`
`153`	`153`
`154`	`154`	`public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()`
`155`	`155`	`{`
`156`		`- if ($this->isLowerThanIcuVersion('4.5')) {`
`157`		`- $this->markTestSkipped('Please upgrade ICU version to 4.5+');`
	`156`	`+ if ($this->isLowerThanIcuVersion('4.7')) {`
	`157`	`+ $this->markTestSkipped('Please upgrade ICU version to 4.7+');`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`\Locale::setDefault('ak');`
`@@ -174,8 +174,8 @@ public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()`
`174`	`174`	`*/`
`175`	`175`	`public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma()`
`176`	`176`	`{`
`177`		`- if ($this->isLowerThanIcuVersion('4.5')) {`
`178`		`- $this->markTestSkipped('Please upgrade ICU version to 4.5+');`
	`177`	`+ if ($this->isLowerThanIcuVersion('4.7')) {`
	`178`	`+ $this->markTestSkipped('Please upgrade ICU version to 4.7+');`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`\Locale::setDefault('en');`
`@@ -189,8 +189,8 @@ public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma()`
`189`	`189`	`*/`
`190`	`190`	`public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma_noGroupSep()`
`191`	`191`	`{`
`192`		`- if ($this->isLowerThanIcuVersion('4.5')) {`
`193`		`- $this->markTestSkipped('Please upgrade ICU version to 4.5+');`
	`192`	`+ if ($this->isLowerThanIcuVersion('4.7')) {`
	`193`	`+ $this->markTestSkipped('Please upgrade ICU version to 4.7+');`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`\Locale::setDefault('en');`