minor #59778 [TwigBridge] Remove legacy code (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit ab8a96feab4a · 2025-02-14T17:03:40.000+01:00
This PR was merged into the 7.3 branch. Discussion ---------- [TwigBridge] Remove legacy code | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #59774 (review) | License | MIT As suggested in the linked comment. Commits ------- ef65035 [TwigBridge] Remove legacy code
diff --git a/src/Symfony/Bridge/Twig/TokenParser/DumpTokenParser.php b/src/Symfony/Bridge/Twig/TokenParser/DumpTokenParser.php
@@ -35,9 +35,7 @@ public function parse(Token $token): Node
     {
         $values = null;
         if (!$this->parser->getStream()->test(Token::BLOCK_END_TYPE)) {
-            $values = method_exists($this->parser, 'parseExpression') ?
-                $this->parseMultitargetExpression() :
-                $this->parser->getExpressionParser()->parseMultitargetExpression();
+            $values = $this->parseMultitargetExpression();
         }
         $this->parser->getStream()->expect(Token::BLOCK_END_TYPE);
 
diff --git a/src/Symfony/Bridge/Twig/TokenParser/FormThemeTokenParser.php b/src/Symfony/Bridge/Twig/TokenParser/FormThemeTokenParser.php
@@ -29,24 +29,20 @@ public function parse(Token $token): Node
         $lineno = $token->getLine();
         $stream = $this->parser->getStream();
 
-        $parseExpression = method_exists($this->parser, 'parseExpression')
-            ? $this->parser->parseExpression(...)
-            : $this->parser->getExpressionParser()->parseExpression(...);
-
-        $form = $parseExpression();
+        $form = $this->parser->parseExpression();
         $only = false;
 
         if ($this->parser->getStream()->test(Token::NAME_TYPE, 'with')) {
             $this->parser->getStream()->next();
-            $resources = $parseExpression();
+            $resources = $this->parser->parseExpression();
 
             if ($this->parser->getStream()->nextIf(Token::NAME_TYPE, 'only')) {
                 $only = true;
             }
         } else {
             $resources = new ArrayExpression([], $stream->getCurrent()->getLine());
             do {
-                $resources->addElement($parseExpression());
+                $resources->addElement($this->parser->parseExpression());
             } while (!$stream->test(Token::BLOCK_END_TYPE));
         }
 
diff --git a/src/Symfony/Bridge/Twig/TokenParser/StopwatchTokenParser.php b/src/Symfony/Bridge/Twig/TokenParser/StopwatchTokenParser.php
@@ -36,9 +36,7 @@ public function parse(Token $token): Node
         $stream = $this->parser->getStream();
 
         // {% stopwatch 'bar' %}
-        $name = method_exists($this->parser, 'parseExpression') ?
-            $this->parser->parseExpression() :
-            $this->parser->getExpressionParser()->parseExpression();
+        $name = $this->parser->parseExpression();
 
         $stream->expect(Token::BLOCK_END_TYPE);
 
diff --git a/src/Symfony/Bridge/Twig/TokenParser/TransDefaultDomainTokenParser.php b/src/Symfony/Bridge/Twig/TokenParser/TransDefaultDomainTokenParser.php
@@ -25,9 +25,7 @@ final class TransDefaultDomainTokenParser extends AbstractTokenParser
 {
     public function parse(Token $token): Node
     {
-        $expr = method_exists($this->parser, 'parseExpression') ?
-            $this->parser->parseExpression() :
-            $this->parser->getExpressionParser()->parseExpression();
+        $expr = $this->parser->parseExpression();
 
         $this->parser->getStream()->expect(Token::BLOCK_END_TYPE);
 
diff --git a/src/Symfony/Bridge/Twig/TokenParser/TransTokenParser.php b/src/Symfony/Bridge/Twig/TokenParser/TransTokenParser.php
@@ -36,33 +36,30 @@ public function parse(Token $token): Node
         $vars = new ArrayExpression([], $lineno);
         $domain = null;
         $locale = null;
-        $parseExpression = method_exists($this->parser, 'parseExpression')
-            ? $this->parser->parseExpression(...)
-            : $this->parser->getExpressionParser()->parseExpression(...);
 
         if (!$stream->test(Token::BLOCK_END_TYPE)) {
             if ($stream->test('count')) {
                 // {% trans count 5 %}
                 $stream->next();
-                $count = $parseExpression();
+                $count = $this->parser->parseExpression();
             }
 
             if ($stream->test('with')) {
                 // {% trans with vars %}
                 $stream->next();
-                $vars = $parseExpression();
+                $vars = $this->parser->parseExpression();
             }
 
             if ($stream->test('from')) {
                 // {% trans from "messages" %}
                 $stream->next();
-                $domain = $parseExpression();
+                $domain = $this->parser->parseExpression();
             }
 
             if ($stream->test('into')) {
                 // {% trans into "fr" %}
                 $stream->next();
-                $locale = $parseExpression();
+                $locale = $this->parser->parseExpression();
             } elseif (!$stream->test(Token::BLOCK_END_TYPE)) {
                 throw new SyntaxError('Unexpected token. Twig was looking for the "with", "from", or "into" keyword.', $stream->getCurrent()->getLine(), $stream->getSourceContext());
             }
diff --git a/src/Symfony/Bridge/Twig/composer.json b/src/Symfony/Bridge/Twig/composer.json
@@ -19,7 +19,7 @@
         "php": ">=8.2",
         "symfony/deprecation-contracts": "^2.5|^3",
         "symfony/translation-contracts": "^2.5|^3",
-        "twig/twig": "^3.12"
+        "twig/twig": "^3.21"
     },
     "require-dev": {
         "egulias/email-validator": "^2.1.10|^3|^4",

Original file line number	Diff line number	Diff line change
`@@ -35,9 +35,7 @@ public function parse(Token $token): Node`
`35`	`35`	`{`
`36`	`36`	`$values = null;`
`37`	`37`	`if (!$this->parser->getStream()->test(Token::BLOCK_END_TYPE)) {`
`38`		`- $values = method_exists($this->parser, 'parseExpression') ?`
`39`		`- $this->parseMultitargetExpression() :`
`40`		`- $this->parser->getExpressionParser()->parseMultitargetExpression();`
	`38`	`+ $values = $this->parseMultitargetExpression();`
`41`	`39`	`}`
`42`	`40`	`$this->parser->getStream()->expect(Token::BLOCK_END_TYPE);`
`43`	`41`
Original file line number	Diff line number	Diff line change
`@@ -25,9 +25,7 @@ final class TransDefaultDomainTokenParser extends AbstractTokenParser`
`25`	`25`	`{`
`26`	`26`	`public function parse(Token $token): Node`
`27`	`27`	`{`
`28`		`- $expr = method_exists($this->parser, 'parseExpression') ?`
`29`		`- $this->parser->parseExpression() :`
`30`		`- $this->parser->getExpressionParser()->parseExpression();`
	`28`	`+ $expr = $this->parser->parseExpression();`
`31`	`29`
`32`	`30`	`$this->parser->getStream()->expect(Token::BLOCK_END_TYPE);`
`33`	`31`