bug #58669 [Cache] Revert "Initialize RedisAdapter cursor to 0" (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit ab60cbfc1af7 · 2024-10-25T17:39:38.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Cache] Revert "Initialize RedisAdapter cursor to 0" | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT I missed integration tests being red, and #58661 is the most likely cause. /cc `@thomas`-hiron Commits ------- 3c0d75f Revert "bug #58661 [Cache] Initialize RedisAdapter cursor to 0 (thomas-hiron)"
diff --git a/src/Symfony/Component/Cache/Traits/RedisTrait.php b/src/Symfony/Component/Cache/Traits/RedisTrait.php
@@ -490,7 +490,7 @@ protected function doClear(string $namespace)
                 continue;
             }
 
-            $cursor = 0;
+            $cursor = null;
             do {
                 $keys = $host instanceof \Predis\ClientInterface ? $host->scan($cursor, 'MATCH', $pattern, 'COUNT', 1000) : $host->scan($cursor, $pattern, 1000);
                 if (isset($keys[1]) && \is_array($keys[1])) {

Original file line number	Diff line number	Diff line change
`@@ -490,7 +490,7 @@ protected function doClear(string $namespace)`
`490`	`490`	`continue;`
`491`	`491`	`}`
`492`	`492`
`493`		`- $cursor = 0;`
	`493`	`+ $cursor = null;`
`494`	`494`	`do {`
`495`	`495`	`$keys = $host instanceof \Predis\ClientInterface ? $host->scan($cursor, 'MATCH', $pattern, 'COUNT', 1000) : $host->scan($cursor, $pattern, 1000);`
`496`	`496`	`if (isset($keys[1]) && \is_array($keys[1])) {`