Use constant var name to cache trans_default_domain expression result

GromNaN · GromNaN · commit ab116bb5021c · 2024-07-01T01:28:28.000+02:00
diff --git a/src/Symfony/Bridge/Twig/NodeVisitor/TranslationDefaultDomainNodeVisitor.php b/src/Symfony/Bridge/Twig/NodeVisitor/TranslationDefaultDomainNodeVisitor.php
@@ -30,6 +30,8 @@
  */
 final class TranslationDefaultDomainNodeVisitor implements NodeVisitorInterface
 {
+    private const INTERNAL_VAR_NAME = '__internal_trans_default_domain';
+
     private Scope $scope;
 
     public function __construct()
@@ -49,9 +51,8 @@ public function enterNode(Node $node, Environment $env): Node
 
                 return $node;
             } else {
-                $var = $this->getVarName();
-                $name = new AssignNameExpression($var, $node->getTemplateLine());
-                $this->scope->set('domain', new NameExpression($var, $node->getTemplateLine()));
+                $name = new AssignNameExpression(self::INTERNAL_VAR_NAME, $node->getTemplateLine());
+                $this->scope->set('domain', new NameExpression(self::INTERNAL_VAR_NAME, $node->getTemplateLine()));
 
                 return new SetNode(false, new Node([$name]), new Node([$node->getNode('expr')]), $node->getTemplateLine());
             }
@@ -111,9 +112,4 @@ private function isNamedArguments(Node $arguments): bool
 
         return false;
     }
-
-    private function getVarName(): string
-    {
-        return \sprintf('__internal_%s', hash('xxh128', uniqid(mt_rand(), true)));
-    }
 }
