8000 feature #21655 [PropertyInfo] Make classes final (GuilhemN) · symfony/symfony@aaa4376 · GitHub
[go: up one dir, main page]
Skip to content

Commit aaa4376

Browse files
nicolas-grekasnicolas-grekas
committed
feature #21655 [PropertyInfo] Make classes final (GuilhemN)
This PR was squashed before being merged into the 3.3-dev branch (closes #21655). Discussion ---------- [PropertyInfo] Make classes final | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The classes of the PropertyInfo component do not provide extension points, so imo it's better to make them final in 4.0. Commits ------- 313fec9 [PropertyInfo] Make classes final
2 parents d08ba63 + 313fec9 commit aaa4376

8 files changed

+37
-4
lines changed

‎UPGRADE-3.3.md

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ DependencyInjection
3838
* Using the `PhpDumper` with an uncompiled `ContainerBuilder` is deprecated and
3939
will not be supported anymore in 4.0.
4040

41+
* Extending the containers generated by `PhpDumper` is deprecated and won't be
42+
supported in 4.0.
43+
4144
* The `DefinitionDecorator` class is deprecated and will be removed in 4.0, use
4245
the `ChildDefinition` class instead.
4346

@@ -58,7 +61,7 @@ FrameworkBundle
5861
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddConsoleCommandPass` has been deprecated. Use `Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass` instead.
5962

6063
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\SerializerPass` class has been
61-
deprecated and will be removed in 4.0.
64+
deprecated and will be removed in 4.0.
6265
Use the `Symfony\Component\Serializer\DependencyInjection\SerializerPass` class instead.
6366

6467
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\FormPass` class has been
@@ -82,6 +85,9 @@ Process
8285

8386
* Configuring Windows and sigchild compatibility is deprecated - they will be always enabled in 4.0.
8487

88+
* Extending `Process::run()`, `Process::mustRun()` and `Process::restart()` is
89+
deprecated and won't be supported in 4.0.
90+
8591
Security
8692
--------
8793

@@ -100,10 +106,16 @@ SecurityBundle
100106
constructor arguments fully provided.
101107
Registering by convention the command or commands extending it is deprecated and will
102108
not be allowed anymore in 4.0.
103-
104-
* `UserPasswordEncoderCommand::getContainer()` is deprecated, and this class won't
109+
110+
* `UserPasswordEncoderCommand::getContainer()` is deprecated, and this class won't
105111
extend `ContainerAwareCommand` nor implement `ContainerAwareInterface` anymore in 4.0.
106112

113+
Serializer
114+
----------
115+
116+
* Extending `ChainDecoder`, `ChainEncoder`, `ArrayDenormalizer` is deprecated
117+
and won't be supported in 4.0.
118+
107119
TwigBridge
108120
----------
109121

‎UPGRADE-4.0.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ DependencyInjection
4848
* Using the `PhpDumper` with an uncompiled `ContainerBuilder` is not supported
4949
anymore.
5050

51+
* Extending the containers generated by `PhpDumper` is not supported
52+
anymore.
53+
5154
* The `DefinitionDecorator` class has been removed. Use the `ChildDefinition`
5255
class instead.
5356

@@ -176,7 +179,7 @@ FrameworkBundle
176179

177180
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddConsoleCommandPass` has been removed. Use `Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass` instead.
178181

179-
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\SerializerPass` class has been removed.
182+
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\SerializerPass` class has been removed.
180183
Use the `Symfony\Component\Serializer\DependencyInjection\SerializerPass` class instead.
181184

182185
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\FormPass` class has been
@@ -242,6 +245,9 @@ Process
242245

243246
* Configuring Windows and sigchild compatibility is not possible anymore - they are always enabled.
244247

248+
* Extending `Process::run()`, `Process::mustRun()` and `Process::restart()` is
249+
not supported anymore.
250+
245251
Security
246252
--------
247253

@@ -259,6 +265,9 @@ Serializer
259265
`AbstractNormalizer::instantiateObject()` method when overriding it is not
260266
supported anymore.
261267

268+
* Extending `ChainDecoder`, `ChainEncoder`, `ArrayDenormalizer` is not supported
269+
anymore.
270+
262271
Translation
263272
-----------
264273

‎src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
* Extracts data using a PHPDoc parser.
2525
*
2626
* @author Kévin Dunglas <dunglas@gmail.com>
27+
*
28+
* @final since version 3.3
2729
*/
2830
class PhpDocExtractor implements PropertyDescriptionExtractorInterface, PropertyTypeExtractorInterface
2931
{

‎src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
* Extracts data using the reflection API.
2222
*
2323
* @author Kévin Dunglas <dunglas@gmail.com>
24+
*
25+
* @final since version 3.3
2426
*/
2527
class ReflectionExtractor implements PropertyListExtractorInterface, PropertyTypeExtractorInterface, PropertyAccessExtractorInterface
2628
{

‎src/Symfony/Component/PropertyInfo/Extractor/SerializerExtractor.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
* Lists available properties using Symfony Serializer Component metadata.
1919
*
2020
* @author Kévin Dunglas <dunglas@gmail.com>
21+
*
22+
* @final since version 3.3
2123
*/
2224
class SerializerExtractor implements PropertyListExtractorInterface
2325
{

‎src/Symfony/Component/PropertyInfo/PropertyInfoCacheExtractor.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* Adds a PSR-6 cache layer on top of an extractor.
1818
*
1919
* @author Kévin Dunglas <dunglas@gmail.com>
20+
*
21+
* @final since version 3.3
2022
*/
2123
class PropertyInfoCacheExtractor implements PropertyInfoExtractorInterface
2224
{

‎src/Symfony/Component/PropertyInfo/PropertyInfoExtractor.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
* Default {@see PropertyInfoExtractorInterface} implementation.
1616
*
1717
* @author Kévin Dunglas <dunglas@gmail.com>
18+
*
19+
* @final since version 3.3
1820
*/
1921
class PropertyInfoExtractor implements PropertyInfoExtractorInterface
2022
{

‎src/Symfony/Component/PropertyInfo/Type.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
* Type value object (immutable).
1616
*
1717
* @author Kévin Dunglas <dunglas@gmail.com>
18+
*
19+
* @final since version 3.3
1820
*/
1921
class Type
2022
{

0 commit comments

Comments
 (0)
0