Update src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php

Spomky · nicolas-grekas · web-flow · commit aa57375f09e8 · 2023-08-21T14:01:16.000+02:00
Co-authored-by: Nicolas Grekas &lt;nicolas.grekas@gmail.com&gt;
diff --git a/src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php b/src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php
@@ -47,8 +47,6 @@ protected function getLimiters(Request $request): array
     {
         $username = $request->attributes->get(SecurityRequestAttributes::LAST_USERNAME, '');
         $username = preg_match('//u', $username) ? mb_strtolower($username, 'UTF-8') : strtolower($username);
-        $ip = $this->secret ? $this->hash($request->getClientIp()) : $request->getClientIp();
-        $usernameAndIp = $this->secret ? $this->hash($username.'-'.$request->getClientIp()) : $username.'-'.$request->getClientIp();
 
         return [
             $this->globalFactory->create($this->hash($ip)),

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,6 @@ protected function getLimiters(Request $request): array`
`47`	`47`	`{`
`48`	`48`	`$username = $request->attributes->get(SecurityRequestAttributes::LAST_USERNAME, '');`
`49`	`49`	`$username = preg_match('//u', $username) ? mb_strtolower($username, 'UTF-8') : strtolower($username);`
`50`		`- $ip = $this->secret ? $this->hash($request->getClientIp()) : $request->getClientIp();`
`51`		`- $usernameAndIp = $this->secret ? $this->hash($username.'-'.$request->getClientIp()) : $username.'-'.$request->getClientIp();`
`52`	`50`
`53`	`51`	`return [`
`54`	`52`	`$this->globalFactory->create($this->hash($ip)),`