[DI] Don't track merged configs when the extension doesn't expose it

nicolas-grekas · nicolas-grekas · commit a8e6aac2f58c · 2017-08-29T15:24:02.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/MergeExtensionConfigurationPass.php b/src/Symfony/Component/DependencyInjection/Compiler/MergeExtensionConfigurationPass.php
@@ -67,7 +67,7 @@ public function process(ContainerBuilder $container)
 
             if ($resolvingBag instanceof MergeExtensionConfigurationParameterBag) {
                 // don't keep track of env vars that are *overridden* when configs are merged
-                $resolvingBag->freezeAfterProcessing($extension);
+                $resolvingBag->freezeAfterProcessing($extension, $tmpContainer);
             }
 
             $container->merge($tmpContainer);
@@ -92,12 +92,16 @@ public function __construct(parent $parameterBag)
         $this->mergeEnvPlaceholders($parameterBag);
     }
 
-    public function freezeAfterProcessing(Extension $extension)
+    public function freezeAfterProcessing(Extension $extension, ContainerBuilder $container)
     {
+        if (!$config = $extension->getProcessedConfigs()) {
+            // Extension::processConfiguration() wasn't called, we cannot know how configs were merged
+            return;
+        }
         $this->processedEnvPlaceholders = array();
 
-        // serialize config to catch env vars nested in object graphs
-        $config = serialize($extension->getProcessedConfigs());
+        // serialize config and container to catch env vars nested in object graphs
+        $config = serialize($config).serialize($container->getDefinitions()).serialize($container->getAliases()).serialize($container->getParameterBag()->all());
 
         foreach (parent::getEnvPlaceholders() as $env => $placeholders) {
             foreach ($placeholders as $placeholder) {
