8000 Log errors instead of thorwing · symfony/symfony@a83cac3 · GitHub
[go: up one dir, main page]

Skip to content

Commit a83cac3

Browse files
committed
Log errors instead of thorwing
1 parent 6d31db9 commit a83cac3

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace Symfony\Bundle\FrameworkBundle\CacheWarmer;
1313

1414
use Psr\Container\ContainerInterface;
15+
use Psr\Log\LoggerInterface;
1516
use Symfony\Bundle\FrameworkBundle\Command\BuildDebugContainerTrait;
1617
use Symfony\Component\Config\Builder\ConfigBuilderGenerator;
1718
use Symfony\Component\Config\Builder\ConfigBuilderGeneratorInterface;
@@ -32,10 +33,12 @@ class ConfigBuilderCacheWarmer implements CacheWarmerInterface
3233
use BuildDebugContainerTrait;
3334

3435
private $kernel;
36+
private $logger;
3537

36-
public function __construct(KernelInterface $kernel)
38+
public function __construct(KernelInterface $kernel, LoggerInterface $logger = null)
3739
{
3840
$this->kernel = $kernel;
41+
$this->logger = $logger;
3942
}
4043

4144
/**
@@ -58,7 +61,9 @@ public function warmUp(string $cacheDir)
5861
try {
5962
$this->dumpExtension($extension, $generator);
6063
} catch (\Throwable $e) {
61-
throw new \RuntimeException(sprintf('Failed to generate ConfigBuilder for extension "%s".', \get_class($extension)), 0, $e);
64+
if ($this->logger) {
65+
$this->logger->warning('Failed to generate ConfigBuilder for extension {extensionClass).', ['exception'=>$e, 'extensionClass'=>\get_class($extension)]);
66+
}
6267
}
6368
}
6469

src/Symfony/Bundle/FrameworkBundle/Resources/config/services.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
use Symfony\Component\Config\ResourceCheckerConfigCacheFactory;
1818
use Symfony\Component\Console\ConsoleEvents;
1919
use Symfony\Component\DependencyInjection\Config\ContainerParametersResourceChecker;
20-
use Symfony\Component\DependencyInjection\ContainerInterface;
2120
use Symfony\Component\DependencyInjection\EnvVarProcessor;
2221
use Symfony\Component\DependencyInjection\ParameterBag\ContainerBag;
2322
use Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface;
@@ -211,7 +210,7 @@ class_exists(WorkflowEvents::class) ? WorkflowEvents::ALIASES : []
211210
service('container.getenv'),
212211
])
213212
->set('config_builder.warmer', ConfigBuilderCacheWarmer::class)
214-
->args([service(KernelInterface::class)])
213+
->args([service(KernelInterface::class), service('logger')->nullOnInvalid(),])
215214
->tag('kernel.cache_warmer')
216215
;
217216
};

0 commit comments

Comments
0 (0)
0