bug #25109 Make debug:container search command case-insensitive (jzawadzki)

fabpot · fabpot · commit a824d3455520 · 2017-11-23T07:30:24.000-08:00
This PR was merged into the 3.3 branch. Discussion ---------- Make debug:container search command case-insensitive | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #25107 | License | MIT | Doc PR | This bug fixes the #25107 - starts from 3.2 services may be written with uppercase (e.g. FQCN) and search fails to match those services. Commits ------- c429c33 Make search in debug:container command case-insensitive
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
@@ -217,9 +217,8 @@ private function findServiceIdsContaining(ContainerBuilder $builder, $name)
     {
         $serviceIds = $builder->getServiceIds();
         $foundServiceIds = array();
-        $name = strtolower($name);
         foreach ($serviceIds as $serviceId) {
-            if (false === strpos($serviceId, $name)) {
+            if (false === stripos($serviceId, $name)) {
                 continue;
             }
             $foundServiceIds[] = $serviceId;

Original file line number	Diff line number	Diff line change
`@@ -217,9 +217,8 @@ private function findServiceIdsContaining(ContainerBuilder $builder, $name)`
`217`	`217`	`{`
`218`	`218`	`$serviceIds = $builder->getServiceIds();`
`219`	`219`	`$foundServiceIds = array();`
`220`		`- $name = strtolower($name);`
`221`	`220`	`foreach ($serviceIds as $serviceId) {`
`222`		`- if (false === strpos($serviceId, $name)) {`
	`221`	`+ if (false === stripos($serviceId, $name)) {`
`223`	`222`	`continue;`
`224`	`223`	`}`
`225`	`224`	`$foundServiceIds[] = $serviceId;`