Review feedback

simonberger · simonberger · commit a7b11f82d849 · 2023-03-15T15:20:11.000+01:00
diff --git a/UPGRADE-6.3.md b/UPGRADE-6.3.md
@@ -60,7 +60,7 @@ FrameworkBundle
 HttpClient
 ----------
 
-* Deprecate the `Http\Client\HttpClient` service, use the `Http\Client\HttpAsyncClient` service for method `::sendAsyncRequest` and `psr18.http_client` for `::sendRequest` instead
+* Deprecate the `Http\Client\HttpClient` service, use the `Http\Client\HttpAsyncClient` service for method `::sendAsyncRequest` and `psr\Http\Client\ClientInterface` for `::sendRequest` instead
 * Deprecate `Symfony\Component\HttpClient\HttplugClient::sendRequest`, use `Psr\Http\Client\ClientInterface::sendRequest` instead
 
 HttpFoundation
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -2432,7 +2432,7 @@ private function registerHttpClientConfiguration(array $config, ContainerBuilder
                 $container->setDefinition('httplug.'.$name, new ChildDefinition(HttpAsyncClient::class))
                     ->replaceArgument(0, new Reference($name));
 
-                $container->registerAliasForArgument('httplug.'.$name, ClientInterface::class, $name);
+                $container->registerAliasForArgument('httplug.'.$name, HttpAsyncClient::class, $name);
             }
         }
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php
@@ -61,7 +61,7 @@
             ->deprecate(
                 'symfony/http-client',
                 '6.3',
-                'The "%alias_id%" service is deprecated, use the "'.HttpAsyncClient::class.'" service for method "::sendAsyncRequest" and "psr18.http_client" for "::sendRequest" instead',
+                'The "%alias_id%" service is deprecated, use the "'.HttpAsyncClient::class.'" service for method "::sendAsyncRequest" and "'.ClientInterface::class.'" for "::sendRequest" instead',
             )
 
         ->set('http_client.abstract_retry_strategy', GenericRetryStrategy::class)

Original file line number	Diff line number	Diff line change
`@@ -2432,7 +2432,7 @@ private function registerHttpClientConfiguration(array $config, ContainerBuilder`
`2432`	`2432`	`$container->setDefinition('httplug.'.$name, new ChildDefinition(HttpAsyncClient::class))`
`2433`	`2433`	`->replaceArgument(0, new Reference($name));`
`2434`	`2434`
`2435`		`- $container->registerAliasForArgument('httplug.'.$name, ClientInterface::class, $name);`
	`2435`	`+ $container->registerAliasForArgument('httplug.'.$name, HttpAsyncClient::class, $name);`
`2436`	`2436`	`}`
`2437`	`2437`	`}`
`2438`	`2438`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@`
`61`	`61`	`->deprecate(`
`62`	`62`	`'symfony/http-client',`
`63`	`63`	`'6.3',`
`64`		`- 'The "%alias_id%" service is deprecated, use the "'.HttpAsyncClient::class.'" service for method "::sendAsyncRequest" and "psr18.http_client" for "::sendRequest" instead',`
	`64`	`+ 'The "%alias_id%" service is deprecated, use the "'.HttpAsyncClient::class.'" service for method "::sendAsyncRequest" and "'.ClientInterface::class.'" for "::sendRequest" instead',`
`65`	`65`	`)`
`66`	`66`
`67`	`67`	`->set('http_client.abstract_retry_strategy', GenericRetryStrategy::class)`