Fix test to be compatible with PHP 5.6

ajgarlag · ajgarlag · commit a736781cc249 · 2019-05-10T09:08:16.000+02:00
diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/VariadicConstructorTypedArgsDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/VariadicConstructorTypedArgsDummy.php
@@ -15,7 +15,7 @@ class VariadicConstructorTypedArgsDummy
 {
     private $foo;
 
-    public function __construct(NullableConstructorArgumentDummy ...$foo)
+    public function __construct(Dummy ...$foo)
     {
         $this->foo = $foo;
     }
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php
@@ -11,6 +11,7 @@
 use Symfony\Component\Serializer\Normalizer\PropertyNormalizer;
 use Symfony\Component\Serializer\Serializer;
 use Symfony\Component\Serializer\Tests\Fixtures\AbstractNormalizerDummy;
+use Symfony\Component\Serializer\Tests\Fixtures\Dummy;
 use Symfony\Component\Serializer\Tests\Fixtures\NullableConstructorArgumentDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\ProxyDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\StaticConstructorDummy;
@@ -139,11 +140,13 @@ public function testObjectWithVariadicConstructorTypedArguments()
     {
         $normalizer = new PropertyNormalizer();
         $normalizer->setSerializer(new Serializer([$normalizer]));
-        $dummy = $normalizer->denormalize(['foo' => [['foo' => null], ['foo' => null]]], VariadicConstructorTypedArgsDummy::class);
-        $this->assertInstanceOf(VariadicConstructorTypedArgsDummy::class, $dummy);
+        $data = ['foo' => [['foo' => 'Foo', 'bar' => 'Bar', 'baz' => 'Baz', 'qux' => 'Qux'], ['foo' => 'FOO', 'bar' => 'BAR', 'baz' => 'BAZ', 'qux' => 'QUX']]];
+        $dummy = $normalizer->denormalize($data, VariadicConstructorTypedArgsDummy::class);
 
+        $this->assertInstanceOf(VariadicConstructorTypedArgsDummy::class, $dummy);
+        $this->assertCount(2, $dummy->getFoo());
         foreach ($dummy->getFoo() as $foo) {
-            $this->assertInstanceOf(NullableConstructorArgumentDummy::class, $foo);
+            $this->assertInstanceOf(Dummy::class, $foo);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ class VariadicConstructorTypedArgsDummy`
`15`	`15`	`{`
`16`	`16`	`private $foo;`
`17`	`17`
`18`		`- public function __construct(NullableConstructorArgumentDummy ...$foo)`
	`18`	`+ public function __construct(Dummy ...$foo)`
`19`	`19`	`{`
`20`	`20`	`$this->foo = $foo;`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`use Symfony\Component\Serializer\Normalizer\PropertyNormalizer;`
`12`	`12`	`use Symfony\Component\Serializer\Serializer;`
`13`	`13`	`use Symfony\Component\Serializer\Tests\Fixtures\AbstractNormalizerDummy;`
	`14`	`+use Symfony\Component\Serializer\Tests\Fixtures\Dummy;`
`14`	`15`	`use Symfony\Component\Serializer\Tests\Fixtures\NullableConstructorArgumentDummy;`
`15`	`16`	`use Symfony\Component\Serializer\Tests\Fixtures\ProxyDummy;`
`16`	`17`	`use Symfony\Component\Serializer\Tests\Fixtures\StaticConstructorDummy;`
`@@ -139,11 +140,13 @@ public function testObjectWithVariadicConstructorTypedArguments()`
`139`	`140`	`{`
`140`	`141`	`$normalizer = new PropertyNormalizer();`
`141`	`142`	`$normalizer->setSerializer(new Serializer([$normalizer]));`
`142`		`- $dummy = $normalizer->denormalize(['foo' => [['foo' => null], ['foo' => null]]], VariadicConstructorTypedArgsDummy::class);`
`143`		`- $this->assertInstanceOf(VariadicConstructorTypedArgsDummy::class, $dummy);`
	`143`	`+ $data = ['foo' => [['foo' => 'Foo', 'bar' => 'Bar', 'baz' => 'Baz', 'qux' => 'Qux'], ['foo' => 'FOO', 'bar' => 'BAR', 'baz' => 'BAZ', 'qux' => 'QUX']]];`
	`144`	`+ $dummy = $normalizer->denormalize($data, VariadicConstructorTypedArgsDummy::class);`
`144`	`145`
	`146`	`+ $this->assertInstanceOf(VariadicConstructorTypedArgsDummy::class, $dummy);`
	`147`	`+ $this->assertCount(2, $dummy->getFoo());`
`145`	`148`	`foreach ($dummy->getFoo() as $foo) {`
`146`		`- $this->assertInstanceOf(NullableConstructorArgumentDummy::class, $foo);`
	`149`	`+ $this->assertInstanceOf(Dummy::class, $foo);`
`147`	`150`	`}`
`148`	`151`	`}`
`149`	`152`	`}`