bug #53634 [Notifer][Smsapi] Set messageId of SentMessage (tomasz-kusy)

nicolas-grekas · nicolas-grekas · commit a67e8bd2d69e · 2024-01-29T21:53:12.000+01:00
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Notifer][Smsapi] Set messageId of SentMessage | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT This commit fixes a bug causing the messageId to never be set in the object. SmsApi always returns it. Commits ------- c97ead7 [Notifer][Smsapi] Set messageId of SentMessage
diff --git a/src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php b/src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php
@@ -84,6 +84,9 @@ protected function doSend(MessageInterface $message): SentMessage
             throw new TransportException(sprintf('Unable to send the SMS: "%s".', $content['message'] ?? 'unknown error'), $response);
         }
 
-        return new SentMessage($message, (string) $this);
+        $sentMessage = new SentMessage($message, (string) $this);
+        $sentMessage->setMessageId($content['list'][0]['id'] ?? '');
+
+        return $sentMessage;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,9 @@ protected function doSend(MessageInterface $message): SentMessage`
`84`	`84`	`throw new TransportException(sprintf('Unable to send the SMS: "%s".', $content['message'] ?? 'unknown error'), $response);`
`85`	`85`	`}`
`86`	`86`
`87`		`- return new SentMessage($message, (string) $this);`
	`87`	`+ $sentMessage = new SentMessage($message, (string) $this);`
	`88`	`+ $sentMessage->setMessageId($content['list'][0]['id'] ?? '');`
	`89`	`+`
	`90`	`+ return $sentMessage;`
`88`	`91`	`}`
`89`	`92`	`}`