minor #19868 [Security] Optimize RoleHierarchy's buildRoleMap method (Enleur)

fabpot · fabpot · commit a630f146598f · 2016-09-06T17:21:47.000-07:00
This PR was squashed before being merged into the 2.7 branch (closes #19868). Discussion ---------- [Security] Optimize RoleHierarchy's buildRoleMap method | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no I have an issue with a large role hierarchy(~150 roles). Optimized it a little bit ![image](https://cloud.githubusercontent.com/assets/858989/18271257/df6c4ba0-7439-11e6-8406-e13bdcefe9ca.png) Commits ------- c3b68b0 [Security] Optimize RoleHierarchy's buildRoleMap method
diff --git a/src/Symfony/Component/Security/Core/Role/RoleHierarchy.php b/src/Symfony/Component/Security/Core/Role/RoleHierarchy.php
@@ -65,9 +65,17 @@ protected function buildRoleMap()
                 }
 
                 $visited[] = $role;
-                $this->map[$main] = array_unique(array_merge($this->map[$main], $this->hierarchy[$role]));
-                $additionalRoles = array_merge($additionalRoles, array_diff($this->hierarchy[$role], $visited));
+
+                foreach ($this->hierarchy[$role] as $roleToAdd) {
+                    $this->map[$main][] = $roleToAdd;
+                }
+
+                foreach (array_diff($this->hierarchy[$role], $visited) as $additionalRole) {
+                    $additionalRoles[] = $additionalRole;
+                }
             }
+
+            $this->map[$main] = array_unique($this->map[$main]);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -65,9 +65,17 @@ protected function buildRoleMap()`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`$visited[] = $role;`
`68`		`- $this->map[$main] = array_unique(array_merge($this->map[$main], $this->hierarchy[$role]));`
`69`		`- $additionalRoles = array_merge($additionalRoles, array_diff($this->hierarchy[$role], $visited));`
	`68`	`+`
	`69`	`+ foreach ($this->hierarchy[$role] as $roleToAdd) {`
	`70`	`+ $this->map[$main][] = $roleToAdd;`
	`71`	`+ }`
	`72`	`+`
	`73`	`+ foreach (array_diff($this->hierarchy[$role], $visited) as $additionalRole) {`
	`74`	`+ $additionalRoles[] = $additionalRole;`
	`75`	`+ }`
`70`	`76`	`}`
	`77`	`+`
	`78`	`+ $this->map[$main] = array_unique($this->map[$main]);`
`71`	`79`	`}`
`72`	`80`	`}`
`73`	`81`	`}`