[HttpClient] skip executing the multi handle when it's freed already

nicolas-grekas · nicolas-grekas · commit a580688ee536 · 2020-10-13T10:06:18.000+02:00
diff --git a/src/Symfony/Component/HttpClient/CurlHttpClient.php b/src/Symfony/Component/HttpClient/CurlHttpClient.php
@@ -320,18 +320,16 @@ public function request(string $method, string $url, array $options = []): Respo
      */
     public function stream($responses, float $timeout = null): ResponseStreamInterface
     {
-        if (!\is_resource($this->multi->handle) && !$this->multi->handle instanceof \CurlMultiHandle) {
-            $responses = [];
-        }
-
         if ($responses instanceof CurlResponse) {
             $responses = [$responses];
         } elseif (!is_iterable($responses)) {
             throw new \TypeError(sprintf('"%s()" expects parameter 1 to be an iterable of CurlResponse objects, "%s" given.', __METHOD__, \is_object($responses) ? \get_class($responses) : \gettype($responses)));
         }
 
-        $active = 0;
-        while (\CURLM_CALL_MULTI_PERFORM === curl_multi_exec($this->multi->handle, $active));
+        if (\is_resource($this->multi->handle) || $this->multi->handle instanceof \CurlMultiHandle) {
+            $active = 0;
+            while (\CURLM_CALL_MULTI_PERFORM === curl_multi_exec($this->multi->handle, $active));
+        }
 
         return new ResponseStream(CurlResponse::stream($responses, $timeout));
     }
