[HttpClient] Fix Failed to open stream: Too many open files

adrienfr · adrienfr · commit a548fe570f8b · 2022-01-19T10:31:25.000+01:00
diff --git a/src/Symfony/Component/HttpClient/Internal/CurlClientState.php b/src/Symfony/Component/HttpClient/Internal/CurlClientState.php
@@ -65,8 +65,9 @@ public function __construct(int $maxHostConnections, int $maxPendingPushes)
             return;
         }
 
-        curl_multi_setopt($this->handle, \CURLMOPT_PUSHFUNCTION, function ($parent, $pushed, array $requestHeaders) use ($maxPendingPushes) {
-            return $this->handlePush($parent, $pushed, $requestHeaders, $maxPendingPushes);
+        // Keep a dummy "onPush" reference to work around a refcount bug in PHP
+        curl_multi_setopt($this->handle, \CURLMOPT_PUSHFUNCTION, $this->onPush = static function ($parent, $pushed, array $requestHeaders) use ($maxPendingPushes) {
+            return self::handlePush($parent, $pushed, $requestHeaders, $maxPendingPushes);
         });
     }
 
@@ -92,7 +93,7 @@ public function reset()
         }
     }
 
-    private function handlePush($parent, $pushed, array $requestHeaders, int $maxPendingPushes): int
+    private static function handlePush($parent, $pushed, array $requestHeaders, int $maxPendingPushes): int
     {
         $headers = [];
         $origin = curl_getinfo($parent, \CURLINFO_EFFECTIVE_URL);

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@ public function __construct(int $maxHostConnections, int $maxPendingPushes)`
`65`	`65`	`return;`
`66`	`66`	`}`
`67`	`67`
`68`		`- curl_multi_setopt($this->handle, \CURLMOPT_PUSHFUNCTION, function ($parent, $pushed, array $requestHeaders) use ($maxPendingPushes) {`
`69`		`- return $this->handlePush($parent, $pushed, $requestHeaders, $maxPendingPushes);`
	`68`	`+ // Keep a dummy "onPush" reference to work around a refcount bug in PHP`
	`69`	`+ curl_multi_setopt($this->handle, \CURLMOPT_PUSHFUNCTION, $this->onPush = static function ($parent, $pushed, array $requestHeaders) use ($maxPendingPushes) {`
	`70`	`+ return self::handlePush($parent, $pushed, $requestHeaders, $maxPendingPushes);`
`70`	`71`	`});`
`71`	`72`	`}`
`72`	`73`
`@@ -92,7 +93,7 @@ public function reset()`
`92`	`93`	`}`
`93`	`94`	`}`
`94`	`95`
`95`		`- private function handlePush($parent, $pushed, array $requestHeaders, int $maxPendingPushes): int`
	`96`	`+ private static function handlePush($parent, $pushed, array $requestHeaders, int $maxPendingPushes): int`
`96`	`97`	`{`
`97`	`98`	`$headers = [];`
`98`	`99`	`$origin = curl_getinfo($parent, \CURLINFO_EFFECTIVE_URL);`