[Debug] Deprecate ExceptionHandler::createResponse

nicolas-grekas · nicolas-grekas · commit a4d2d31f1bcd · 2015-08-01T08:34:55.000+02:00
diff --git a/src/Symfony/Component/Debug/ExceptionHandler.php b/src/Symfony/Component/Debug/ExceptionHandler.php
@@ -164,6 +164,7 @@ private function failSafeHandle(\Exception $exception)
             $response = $this->createResponse($exception);
             $response->sendHeaders();
             $response->sendContent();
+            @trigger_error(sprintf("The %s::createResponse method is deprecated since 2.8 and won't be called anymore when handling an exception in 3.0.", $reflector->class), E_USER_DEPRECATED);
 
             return;
         }
@@ -202,9 +203,13 @@ public function sendPhpResponse($exception)
      * @param \Exception|FlattenException $exception An \Exception instance
      *
      * @return Response A Response instance
+     *
+     * @deprecated since 2.8, to be removed in 3.0.
      */
     public function createResponse($exception)
     {
+        @trigger_error('The '.__METHOD__.' method is deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED);
+
         if (!$exception instanceof FlattenException) {
             $exception = FlattenException::create($exception);
         }

Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,7 @@ private function failSafeHandle(\Exception $exception)`
`164`	`164`	`$response = $this->createResponse($exception);`
`165`	`165`	`$response->sendHeaders();`
`166`	`166`	`$response->sendContent();`
	`167`	`+ @trigger_error(sprintf("The %s::createResponse method is deprecated since 2.8 and won't be called anymore when handling an exception in 3.0.", $reflector->class), E_USER_DEPRECATED);`
`167`	`168`
`168`	`169`	`return;`
`169`	`170`	`}`
`@@ -202,9 +203,13 @@ public function sendPhpResponse($exception)`
`202`	`203`	`* @param \Exception\|FlattenException $exception An \Exception instance`
`203`	`204`	`*`
`204`	`205`	`* @return Response A Response instance`
	`206`	`+ *`
	`207`	`+ * @deprecated since 2.8, to be removed in 3.0.`
`205`	`208`	`*/`
`206`	`209`	`public function createResponse($exception)`
`207`	`210`	`{`
	`211`	`+ @trigger_error('The '.__METHOD__.' method is deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED);`
	`212`	`+`
`208`	`213`	`if (!$exception instanceof FlattenException) {`
`209`	`214`	`$exception = FlattenException::create($exception);`
`210`	`215`	`}`