Merge branch '3.4' into 4.1

nicolas-grekas · nicolas-grekas · commit a4bc4ac0ceb2 · 2018-11-30T09:55:04.000+01:00
* 3.4:
  typo
  add a test case
  [Form] Handle all case variants of "nan" when parsing a number
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
@@ -146,7 +146,7 @@ public function reverseTransform($value)
             return;
         }
 
-        if ('NaN' === $value) {
+        if (\in_array($value, array('NaN', 'NAN', 'nan'), true)) {
             throw new TransformationFailedException('"NaN" is not a valid number');
         }
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -514,24 +514,24 @@ public function testReverseTransformExpectsValidNumber()
 
     /**
      * @expectedException \Symfony\Component\Form\Exception\TransformationFailedException
+     * @dataProvider nanRepresentationProvider
      *
      * @see https://github.com/symfony/symfony/issues/3161
      */
-    public function testReverseTransformDisallowsNaN()
+    public function testReverseTransformDisallowsNaN($nan)
     {
         $transformer = new NumberToLocalizedStringTransformer();
 
-        $transformer->reverseTransform('NaN');
+        $transformer->reverseTransform($nan);
     }
 
-    /**
-     * @expectedException \Symfony\Component\Form\Exception\TransformationFailedException
-     */
-    public function testReverseTransformDisallowsNaN2()
+    public function nanRepresentationProvider()
     {
-        $transformer = new NumberToLocalizedStringTransformer();
-
-        $transformer->reverseTransform('nan');
+        return array(
+            array('nan'),
+            array('NaN'), // see https://github.com/symfony/symfony/issues/3161
+            array('NAN'),
+        );
     }
 
     /**
diff --git a/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php b/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php
@@ -112,7 +112,7 @@ public function getValidator();
      * Returns the currently validated object.
      *
      * If the validator is currently validating a class constraint, the
-     * object of that class is returned. If it is a validating a property or
+     * object of that class is returned. If it is validating a property or
      * getter constraint, the object that the property/getter belongs to is
      * returned.
      *

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ public function reverseTransform($value)`
`146`	`146`	`return;`
`147`	`147`	`}`
`148`	`148`
`149`		`- if ('NaN' === $value) {`
	`149`	`+ if (\in_array($value, array('NaN', 'NAN', 'nan'), true)) {`
`150`	`150`	`throw new TransformationFailedException('"NaN" is not a valid number');`
`151`	`151`	`}`
`152`	`152`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public function getValidator();`
`112`	`112`	`* Returns the currently validated object.`
`113`	`113`	`*`
`114`	`114`	`* If the validator is currently validating a class constraint, the`
`115`		`- * object of that class is returned. If it is a validating a property or`
	`115`	`+ * object of that class is returned. If it is validating a property or`
`116`	`116`	`* getter constraint, the object that the property/getter belongs to is`
`117`	`117`	`* returned.`
`118`	`118`	`*`